Date: Wed, 30 Mar 2005 12:07:22 -0500 (EST) From: "Jim Trigg" <jtrigg@spamcop.net> To: "Karl Denninger" <karl@denninger.net> Cc: "Matthew N. Dodd" <mdodd@freebsd.org> Subject: Re: DANGER WILL ROBINSON! SERIOUS problem with current 5.4-PRERELEASE Message-ID: <44027.128.222.32.10.1112202442.squirrel@mail.scadian.net> In-Reply-To: <20050329234318.A3883@denninger.net> References: <20050329200841.A772@denninger.net> <20050329233843.L328@sasami.jurai.net> <20050329230830.A3222@denninger.net> <20050329234318.A3883@denninger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, March 30, 2005 12:43 am, Karl Denninger said:
> Here's the diff and some thoughts....
[snip, including first diff]
> 241,243c244,249
> <
> < /* if reinit succeeded and retries still permit, reinject request
> */
> < if (ata_reinit(ch) && request->retries-- > 0 &&
> request->device->param){
> ---
>> /*
>> * if reinit succeeds, retries still permit and device didn't
>> * get removed by the reinit, reinject request
>> */
>> if (!ata_reinit(ch) && request->retries-- > 0
>> && request->device->param){
[snip third diff]
> The second diff is really just a formatting and comment change.. you're
> certainly correct that the changes are small! :-)
No, it is not -- it reverses the sense of the first condition. At first
glance that is what I would expect to be the core of the problem, but I
don't have appropriate hardware to test on. (It also adds a third
condition, but that is presumably the intent of the change and should give
the desired results once the first condition is corrected.)
Jim
--
Jim Trigg, Lord High Everything Else O- /"\
Hostmaster, Huie Kin family website \ / ASCII RIBBON CAMPAIGN
Verger and System Administrator, X HELP CURE HTML MAIL
All Saints Church - Sharon Chapel / \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44027.128.222.32.10.1112202442.squirrel>