Date: Wed, 04 Jun 2014 00:04:36 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r267029 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <538EA8E4.1070300@FreeBSD.org> In-Reply-To: <201406032106.s53L63oR085624@svn.freebsd.org> References: <201406032106.s53L63oR085624@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On 6/3/2014 4:06 PM, Alexander Motin wrote: > Author: mav > Date: Tue Jun 3 21:06:03 2014 > New Revision: 267029 > URL: http://svnweb.freebsd.org/changeset/base/267029 > > Log: > Replace gethrtime() with cpu_ticks(), as source of random for the taskqueue > selection. gethrtime() in our port updated with HZ rate, so unusable for > this specific purpose, completely draining benefit of multiple taskqueues. > > MFC after: 2 weeks > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun 3 21:02:19 2014 (r267028) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Tue Jun 3 21:06:03 2014 (r267029) > @@ -953,7 +953,7 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_t > if (tqs->stqs_count == 1) { > tq = tqs->stqs_taskq[0]; > } else { > - tq = tqs->stqs_taskq[gethrtime() % tqs->stqs_count]; > + tq = tqs->stqs_taskq[cpu_ticks() % tqs->stqs_count]; > } > > taskq_dispatch_ent(tq, func, arg, flags, ent); > FYI r267038. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTjqjoAAoJEDXXcbtuRpfPBDkIALkJ7A+OSts7Jh8BjLix2D63 Kp5snxnJOwruIKfeSpDvE8VXFwVHPTpoXltl7YgoepvlEdLoFTq2+IDvWqyROiX+ rgd2AWn5xgM7pV67HZe8YtZRBTXZ0HNyzQ40Sy2ZbS0udeq1hLqjMUBUy/12cmDG +Jw8oVylwsP62CJiLzaX/GBuLGPq4sitBn3yqj0sMgp9zsJHQ2brS/UXkcy07vhz kqqoVSLZT3Lnmefs9u/2NDc0l0g0RCfbxqi7UMQPN9qHyFpXXEuUnjL1YiQNG80S /z/cKe8wOklXEkqShtsNleiyVlXPrag8yqw51UkpEVci+MzyhW9SKhRxAVdHgOw= =8+rR -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?538EA8E4.1070300>