Date: Wed, 19 Sep 2018 10:13:22 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: java@FreeBSD.org Subject: Fwd: Request for Approval: Backport of JDK-8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK Message-ID: <19EDB12C-A2AE-4B49-BEE4-5215138985A3@FreeBSD.org> References: <58ed90b3-ee3d-9c8b-70a3-b7f3a7398040@loongson.cn>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] FYI. I'm testing this patch (at http://cr.openjdk.java.net/~zgu/8205965_8u/webrev.00/ ) locally, which reverts the fix we committed for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225054 in https://svnweb.freebsd.org/ports?view=revision&revision=459368, and solves the issue in another way. -Dimitry > Begin forwarded message: > > From: Leslie Zhai <zhaixiang@loongson.cn> > Subject: Re: Request for Approval: Backport of JDK-8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK > Date: 19 September 2018 at 03:22:48 CEST > To: Zhengyu Gu <zgu@redhat.com>, Seán Coffey <sean.coffey@oracle.com> > Cc: jdk8u-dev <jdk8u-dev@openjdk.java.net>, Dimitry Andric <dimitry@andric.com> > > Hi Zhengyu, > > Thanks for your sponsor! > > I will run jtreg towards: > > * jdk8u-dev, base on 8722:16b9bbfaa450, applied with the patch, compiled with clang-6 and clang-8-dev > > * jdk8u-dev, base on 8722:16b9bbfaa450, compiled with gcc-6.4.3 and gcc-9-dev > > Then run jtdiff on Linux X86. > > Hi Dimitry, > > Please verify the patch on FreeBSD compiled with clang-6, thanks a lot! > > Thanks, > > Leslie Zhai > > > 在 2018年09月19日 07:06, Zhengyu Gu 写道: >> Hi Leslie, >> >> The backport is approved. >> >> Please send me *committed* patch [1] after proper tests, I will sponsor it for you. >> >> Thanks, >> >> -Zhengyu >> >> [1] http://openjdk.java.net/sponsor/ Section 3 >> >> You should use commit message from original patch and add yourself as contributor, ex. >> >> 8205965: SIGSEGV on write to NativeCallStack::EMPTY_STACK >> Summary: Made EMPTY_STACK non-const, so it will not be placed in read-only BSS section. >> Reviewed-by: stuefe, martin >> Contributed-by: zhaixiang@loongson.cn >> >> >> >> On 09/18/2018 06:28 PM, Seán Coffey wrote: >>> Approved for jdk8u-dev. >>> >>> regards, >>> Sean. >>> >>> >>> On 18/09/2018 07:48, Leslie Zhai wrote: >>>> Hi Zhengyu, >>>> >>>> I would like to backport the fix for: >>>> >>>> https://bugs.openjdk.java.net/browse/JDK-8205965 >>>> >>>> To OpenJDK 8 updates dev: >>>> >>>> http://hg.openjdk.java.net/jdk8u/jdk8u-dev >>>> >>>> The fix is mostly the same as the version that was committed in 12, here is the patch: >>>> >>>> http://cr.openjdk.java.net/~zgu/8205965_8u/webrev.00/ >>>> >>>> The patch was reviewed, thanks for your review! Here is the relevant thread: >>>> >>>> http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-September/007860.html >>>> >>>> A patch by Loongson! Please sponsor it, thanks a lot! >>>> >>> > > [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW6IFIgAKCRCwXqMKLiCW o2tKAKDjLRUVmbBQM7J2T6kSgkyLYk/6owCfUAEejztheG7TIbomV4quMT+R2tk= =jVbt -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19EDB12C-A2AE-4B49-BEE4-5215138985A3>