Date: Thu, 23 Jul 2009 21:38:49 +0300 From: Jaakko Heinonen <jh@saunalahti.fi> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r195693 - in head: lib/libc/sys sys/vm Message-ID: <20090723183849.GB3773@a91-153-125-115.elisa-laajakaista.fi> In-Reply-To: <200907230845.21147.jhb@freebsd.org> References: <200907141945.n6EJjaMC069356@svn.freebsd.org> <20090723103014.GA2316@a91-153-125-115.elisa-laajakaista.fi> <200907230845.21147.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2009-07-23, John Baldwin wrote: > > After this change locate(1) gives an obscure error message for empty > > database files. > > Ah, odd. Perhaps it would be best to just move the original "too > small" check earlier: Looks good to me except you should use "db" instead of "database" in search_mmap(). > + if (len < (2*NBG)) > + errx(1, "database too small: %s", database); Thanks. -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090723183849.GB3773>