Date: Wed, 10 Jul 2013 11:13:07 -0700 From: Xin Li <delphij@delphij.net> To: "Justin T. Gibbs" <gibbs@FreeBSD.org> Cc: freebsd-fs@freebsd.org, =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= <des@des.no>, d@delphij.net, ivoras@freebsd.org, freebsd-hackers@freebsd.org Subject: Re: Make ZFS use the physical sector size when computing initial ashift Message-ID: <51DDA433.7040707@delphij.net> In-Reply-To: <2B9367B6-8759-45C9-B120-9D00A381228F@FreeBSD.org> References: <86zjtupz3r.fsf@nine.des.no> <51DD9801.4090808@delphij.net> <2B9367B6-8759-45C9-B120-9D00A381228F@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 07/10/13 10:38, Justin T. Gibbs wrote: [snip] > I'm sure lots of folks have "some solution" to this. Here is an > old version of what we use at Spectra: > > http://people.freebsd.org/~gibbs/zfs_patches/zfs_auto_ashift.diff > > The above patch is missing some cleanup that was motivated by my > discussions with George Wilson about this change in April. I'll > dig that up later tonight. Even if you don't read the full diff, > please read the included checkin comment since it explains the > motivation behind this particular solution. > > This is on my list of things to upstream in the next week or so > after I add logic to the userspace tools to report whether or not > the TLVs in a pool are using an optimal allocation size. This is > only possible if you actually make ZFS fully aware of logical, > physical, and the configured allocation size. All of the other > patches I've seen just treat physical as logical. Yes, me too. Your version is superior. Cheers, - -- Xin LI <delphij@delphij.net> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- iQEcBAEBCgAGBQJR3aQzAAoJEG80Jeu8UPuzHn8H/1ZpoTqAQ4+mgQOttOwXgBcr 2Fgh52ztW8fCEQSeIosxXKO06hP7HxFfTPvmeeWyjT8zIpSUSFV6G0NclebKDncP huGFofvx3BKPRmfzZp4iZx1wWQUxSHTmv6ceDwvP7P8GJ0mON+SrZxmmwUjKrf7V W9Sazl0p8e0nxSQykLyjjrkaBx5Iv+aUxu8Alomwy9BmpM8+gd2yutvzghW5L36L 0CvAtIMXdlc+eUdAqa/2rOk/nMOA9sfWVW0gkKYCZk6wvj2DMzjii05UechZ4Z+l 6nEU3UdVsbTX73CABZv4my4JAWc5Yk1s/cWrxtn68AfK8LMPFJCJcVXXOSckMWI= =351W -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51DDA433.7040707>