Date: Tue, 12 Dec 2017 09:05:37 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: rgrimes@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Nathan Whitehorn <nwhitehorn@freebsd.org>, Kyle Evans <kevans@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326773 - in head/sys: conf dev/syscon Message-ID: <201712121705.vBCH5bHb087173@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <20171212165828.e9a0eb263cc4dca94d0d6ca9@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Tue, 12 Dec 2017 07:40:21 -0800 (PST) > "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > > > > On Tue, 12 Dec 2017 06:18:36 +0000 > > > Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > > > > > > On Mon, Dec 11, 2017 at 10:14:04AM -0800, Nathan Whitehorn wrote: > > > > > I think this name might confuse people looking for "syscons". Can it be > > > > > renamed? Also, if it is ARM-specific, maybe it belongs in sys/arm? > > > > > > > > +1 for rename, it's very confusing now. > > > > ++1 rename it or expect irrate users > > So where exactly in the confusion ? > > Is it because your tab completion when doing cd sys/dev/sysc<tab> will > now ask you to type more char ? > This is the only place where "syscons" (not syscon) exists. My appologies, I did not notice that there infact is a delta of syscon vs syscons. I thought that the name was an exact match. I still not real happy with it, but my objection is retracted. > > > > > > > > ./danfe > > > > > > It's not confusing. The spec is clear it's named "syscon" so our > > > driver must be named syscon, naming it otherwise would be confusing. > > > What's confusing is the directory name for "sc" named syscons, it's > > > config options are named SC_* and the device is named sc. > > > > The spec is wrong for dictating what any implementation must > > call this, the spec does not own the implementation name space. > > > > It is called called syscons and uses the variables and driver > > names sc beacuse that is what we did back in the 90's, drivers > > typically had 2 character names. > > > > > The only valuable remark in this thread is bde's one saying it's not > > > documented etc ... and yes we do sucks in this area in the arm world. > > > > Thank you for your dismissal of input from the community, does that > > mean your gong to ignore them? > > > > > Anyhow, I caught a discussion between mmel@ and kevans@ on IRC saying > > > that we will move the driver into extres after adding some standard > > > stuff common to extres framework. > > > > FYI why is this so bad an idea to call it syscons: > > man syscons > > How do you plan to resolve that name space conflict? > > AND this man page has existed since 1.0, So 25 years of > > finger memory, your just not gona do well trying to change that. > > The new driver name is "syscon" not "syscons", there is no name space > conflict. Again, I am sorry, I did not notice this and thought we had a direct conflict. > > Again, we will move it to sys/dev/extres, now can we stop whining > about small details like that and do some actual work please ? I am glad it is moving, but that was never the reason that someone raised issue. Please stop dismissing concerns, especially if raised by more than one person, as whining, that is not helpful. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712121705.vBCH5bHb087173>