Date: Thu, 14 May 2015 02:23:30 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: John-Mark Gurney <jmg@funkthat.com>, Ian Lepore <ian@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, Hans Petter Selasky <hps@selasky.org>, David Chisnall <theraven@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, "current@freebsd.org" <current@freebsd.org> Subject: Re: Increase BUFSIZ to 8192 Message-ID: <6AE8973B-3C03-497F-85A9-96C4D464B4BD@gmail.com> In-Reply-To: <77887.1431590789@critter.freebsd.dk> References: <14994.1431412293@critter.freebsd.dk> <20150513080342.GE37063@funkthat.com> <A1224018-7540-4C76-91EF-AEA2655E49A8@FreeBSD.org> <55530CC3.1090204@selasky.org> <1431528249.1221.15.camel@freebsd.org> <CAJ-VmonL9mT4JLqfSefKYiwv5-ecLkx9RZ5=kXt__%2Bs9iO4%2B9Q@mail.gmail.com> <20150513181347.GM37063@funkthat.com> <1431542835.1221.30.camel@freebsd.org> <20150514072155.GT37063@funkthat.com> <62511.1431589335@critter.freebsd.dk> <20150514075316.GY37063@funkthat.com> <77887.1431590789@critter.freebsd.dk>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On May 14, 2015, at 1:06, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote: > -------- > In message <20150514075316.GY37063@funkthat.com>, John-Mark Gurney writes: >> Poul-Henning Kamp wrote this message on Thu, May 14, 2015 at 07:42 +0000: >>> -------- >>> In message <20150514072155.GT37063@funkthat.com>, John-Mark Gurney writes: >>> >>>> Since you apprently missed my original reply, I said that we shouldn't >>>> abuse BUFSIZ for this work, and that it should be changed in mdXhl.c... >>> >>> Say what ? >>> >>> BUFSIZ is used entirely appropriately in MDXFileChunk(): For reading >>> a file into an algorithm. > >> In fact, posix-2008 references LINE_MAX because: > > MDXFileChunk() does not read lines, it reads an entire file. Being pedantic, technically it’s a portion of a file, which can be the whole thing, and it reads it in “sizeof(buffer)” chunks (of which buffer is “hardcoded" to BUFSIZ right now). Cheers! [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVVGmSAAoJEMZr5QU6S73eVIYIALM8mAuABG5q2xHdTaR5TqaR YbazmhKDn4ZUke+pd7BcyNstQKD4hNMkU+ZIZsvevH+0PINAmUrLRfu++lYFhSM7 239VCHwqGlJLOAuE+HyfcM1fURo85hYRkIgbPNRw0iwJ6HEvIudyR5KYW0nsHceO Gw3EX7ZHxDdeupZ/dkG4oiJIhAUc6HgPFcHvsy/kBRwrH6zrjSGldmqoQaotYQLR muQwGCFq/cq++4bu5Nr4S90UKNeRluRSXbAAd8QaSTPvgAK3R99l4uv0saIzyeO8 JHj+j8r7O5R3Hfa4035Y6V+5kWv8Ha8odykFo3+YsN2WPR62cK6IWZmDPtKFTpo= =MLZT -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6AE8973B-3C03-497F-85A9-96C4D464B4BD>