Date: Tue, 27 Nov 2012 17:08:31 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, David Xu <davidxu@freebsd.org> Subject: Re: svn commit: r243599 - head/sys/kern Message-ID: <20121127150831.GK3013@kib.kiev.ua> In-Reply-To: <50B48EE9.1090506@FreeBSD.org> References: <201211270607.qAR67w6O094153@svn.freebsd.org> <50B48EE9.1090506@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--sCNd3Ivk/oijKKf1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 27, 2012 at 11:59:05AM +0200, Andriy Gapon wrote: > on 27/11/2012 08:07 David Xu said the following: > > Author: davidxu > > Date: Tue Nov 27 06:07:58 2012 > > New Revision: 243599 > > URL: http://svnweb.freebsd.org/changeset/base/243599 > >=20 > > Log: > > Take first active vnode correctly. > > =20 > > Reviewed by: kib > > MFC after: 3 days > >=20 > > Modified: > > head/sys/kern/vfs_subr.c > >=20 > > Modified: head/sys/kern/vfs_subr.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/kern/vfs_subr.c Tue Nov 27 06:01:02 2012 (r243598) > > +++ head/sys/kern/vfs_subr.c Tue Nov 27 06:07:58 2012 (r243599) > > @@ -4755,7 +4755,7 @@ __mnt_vnode_first_active(struct vnode ** > > MNT_REF(mp); > > (*mvp)->v_type =3D VMARKER; > > =20 > > - vp =3D TAILQ_NEXT(*mvp, v_actfreelist); > > + vp =3D TAILQ_FIRST(&mp->mnt_activevnodelist); > > while (vp !=3D NULL) { > > VI_LOCK(vp); > > if (vp->v_mount =3D=3D mp && vp->v_type !=3D VMARKER && > >=20 >=20 > Oh, wow, did this even work before? > Did it always just return NULL and no active list iteration happened? Yes. Due to some redundancy in the VFS, the consequences were much less fatal than it could be. --sCNd3Ivk/oijKKf1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC0124ACgkQC3+MBN1Mb4gGvQCfTPP6l/tIlnZiC7jh8URJEART CT4AoImg06M5EDKf960V1RC0gfiQWiNZ =Oqaj -----END PGP SIGNATURE----- --sCNd3Ivk/oijKKf1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121127150831.GK3013>