Date: Mon, 05 Aug 2002 13:39:52 +0300 From: Maxim Sobolev <sobomax@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/x11/xscreensaver Makefile pkg-plistports/x11/xscreensaver/files patch-driver_Makefile.in Message-ID: <3D4E55F8.236A22CE@FreeBSD.org> References: <200208051014.g75AEeXl044928@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton wrote: > > dougb 2002/08/05 03:14:40 PDT > > Modified files: > x11/xscreensaver Makefile pkg-plist > Removed files: > x11/xscreensaver/files patch-driver_Makefile.in > Log: > Take the unfortunate step of removing gnome support. The gnome team > already has xscreensaver-gnome to work with, and I think they'll > do a great job with it. This is not a rash decision. I've discussed > the issue several times with the gnome team, and suffice it to say > that we have different ideas about how things should look. I've also > sent an e-mail directly to them describing the reasoning for my > decision in more detail. There was actually no GNOME support, so please don't whine when the port will be broken by removal of bsd.gnome.mk (is is going to be removed and replaced with bsd.gnomeng.mk, so that USE_GTK and friends will go away). Also, your rev.1.15 of patch-ab was absolutely unjustified, as its sole purpose was to prevent configure script from detecting/using gtk-2.0.x/libxml-2.0.x instead of gtk-1.0.x/libxml-1.0.x when it is not asked for, which obviously will lead to missing dependency when user builds xscreensaver on machine with gnome2 installed. You had 20+ days to review proposed patches, but didn't even make an 10-minutes worth effort to understand their purpose. Doh. -Maxim > > Since I'm here, make not wanting Kerberos explicit. Several users > who've had various bits and pieces of Kerberos left behind after > trying to remove it have reported that the configure script is > a little overzealous about finding those bits, and we end up > with either a failed build, or a less than completely successful > binary. If this becomes a problem we can revisit it. > > Revision Changes Path > 1.60 +29 -9 ports/x11/xscreensaver/Makefile > 1.1 +0 -0 ports/x11/xscreensaver/files/patch-driver_Makefile.in (dead) > 1.36 +0 -18 ports/x11/xscreensaver/pkg-plist To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D4E55F8.236A22CE>