Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 16 Mar 2020 10:28:13 +0900 (JST)
From:      Mori Hiroki <yamori813@yahoo.co.jp>
To:        "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>
Subject:   log at access to framebuffer
Message-ID:  <1009057156.3183549.1584322093930.JavaMail.yahoo@mail.yahoo.co.jp>
References:  <1009057156.3183549.1584322093930.JavaMail.yahoo.ref@mail.yahoo.co.jp>

index | next in thread | previous in thread | raw e-mail

Hi

I write data to framebuffer then I get this log on console.

WARNING: Device driver fb has set "memattr" inconsistently (drv 0 pmap 3).


I want delete this log. I make patch to fb. Is this correct ?

diff --git a/sys/dev/fb/creator.c b/sys/dev/fb/creator.c
index 2fd0bd10597..0f8d997a887 100644
--- a/sys/dev/fb/creator.c
+++ b/sys/dev/fb/creator.c
@@ -184,7 +184,7 @@static d_mmap_t creator_fb_mmap;
 
 static struct cdevsw creator_fb_devsw = {
        .d_version =    D_VERSION,
-       .d_flags =      D_NEEDGIANT,
+      .d_flags =      D_MEM | D_NEEDGIANT,
        .d_open =       creator_fb_open,
        .d_close =      creator_fb_close,
        .d_ioctl =      creator_fb_ioctl,
diff --git a/sys/dev/fb/fb.c b/sys/dev/fb/fb.c
index 2f821c8b65f..98bf7a4e58e 100644
--- a/sys/dev/fb/fb.c
+++ b/sys/dev/fb/fb.c
@@ -365,7 +365,7 @@static d_mmap_t             fbmmap;
 
 static struct cdevsw fb_cdevsw = {
        .d_version =    D_VERSION,
-       .d_flags =      D_NEEDGIANT,
+      .d_flags =      D_MEM | D_NEEDGIANT,
        .d_open =       fbopen,
        .d_close =      fbclose,
        .d_read =       fbread,
diff --git a/sys/dev/fb/fbd.c b/sys/dev/fb/fbd.c
index 02b8eb3ada4..8298d95def3 100644
--- a/sys/dev/fb/fbd.c
+++ b/sys/dev/fb/fbd.c
@@ -84,7 +84,7 @@static d_mmap_t               fb_mmap;
 
 static struct cdevsw fb_cdevsw = {
        .d_version =    D_VERSION,
-       .d_flags =      D_NEEDGIANT,
+      .d_flags =      D_MEM | D_NEEDGIANT,
        .d_open =       fb_open,
        .d_close =      fb_close,



home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1009057156.3183549.1584322093930.JavaMail.yahoo>