Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Dec 2018 18:05:10 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Mark Linimon <linimon@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r488033 - head/science/InsightToolkit/files
Message-ID:  <8t0h-1ohl-wny@FreeBSD.org>
In-Reply-To: <201812220052.wBM0qV0S051606@repo.freebsd.org> (Mark Linimon's message of "Sat, 22 Dec 2018 00:52:31 %2B0000 (UTC)")
References:  <201812220052.wBM0qV0S051606@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Mark Linimon <linimon@FreeBSD.org> writes:

> Author: linimon
> Date: Sat Dec 22 00:52:31 2018
> New Revision: 488033
> URL: https://svnweb.freebsd.org/changeset/ports/488033
>
> Log:
>   This port currently doesn't build on GCC-based architectures, due to
>   not supporting GCC8.  Make GCC8 use the same macros as the newest
>   supported version, GCC 7.3.
[...]
> +@@ -86,6 +86,9 @@
> + #  else
> + #   define VCL_GCC_70
> + #  endif
> ++#  elif (__GNUC__==8)
> ++#   define VCL_GCC_7
> ++#   define VCL_GCC_73
> + # else
> + #  error "Dunno about this gcc"
> + # endif

Confusing indentation. #elif after #endif would be a syntax error but
(__GNUC__==8) isn't actually under (__GNUC__==7) branch.

Can you shift the new lines left by one space?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8t0h-1ohl-wny>