Date: Wed, 16 Nov 2011 10:45:42 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Attilio Rao <attilio@freebsd.org> Cc: mdf@freebsd.org, "K. Macy" <kmacy@freebsd.org>, Alan Cox <alc@rice.edu>, Andriy Gapon <avg@freebsd.org>, freebsd-current@freebsd.org, Benjamin Kaduk <kaduk@mit.edu>, Penta Upa <bsdboot@gmail.com> Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] Message-ID: <20111116084542.GY50300@deviant.kiev.zoral.com.ua> In-Reply-To: <CAJ-FndDsrVk7EjjtE=QuhaJE1_k7Q1BvQ%2BxriJPnGzLXJQr1sg@mail.gmail.com> References: <4EB4095D.3030303@rice.edu> <20111104160339.GM50300@deviant.kiev.zoral.com.ua> <20111105141306.GW50300@deviant.kiev.zoral.com.ua> <CAMBSHm86TaJnRRgmPA_t7tiPfQsPyoTqz3ymdHSY1H3t5G864Q@mail.gmail.com> <20111105151530.GX50300@deviant.kiev.zoral.com.ua> <4EB595FA.4020500@rice.edu> <20111106124331.GP50300@deviant.kiev.zoral.com.ua> <4EB81942.70501@rice.edu> <20111107193516.GA50300@deviant.kiev.zoral.com.ua> <CAJ-FndDsrVk7EjjtE=QuhaJE1_k7Q1BvQ%2BxriJPnGzLXJQr1sg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--oe1auVEEt6MAu8AG Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: > 2011/11/7 Kostik Belousov <kostikbel@gmail.com>: > > On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: > >> Ok. =9AI'll offer one final suggestion. =9APlease consider an alternat= ive > >> suffix to "func". =9APerhaps, "kbi" or "KBI". =9AIn other words, somet= hing > >> that hints at the function's reason for existing. > > > > Sure. Below is the extraction of only vm_page_lock() bits, together > > with the suggested rename. When Attilio provides the promised simplific= ation > > of the mutex KPI, this can be reduced. >=20 > My tentative patch is here: > http://www.freebsd.org/~attilio/mutexfileline.patch >=20 > I need to make more compile testing later, but it already compiles > GENERIC + modules fine on HEAD. >=20 > The patch provides a common entrypoint, option independent, for both > fast case and debug/compat case. > Additively, it almost entirely fixes the standard violation of the > reserved namespace, as you described (the notable exception being the > macro used in the fast path, that I want to fix as well, but in a > separate commit). >=20 > Now the file/line couplet can be passed to the "_" suffix variant of > the flag functions. Yes, this is exactly KPI that I would use when available for the vm_page_lock() patch. >=20 > eadler@ reviewed the mutex.h comment. >=20 > Please let me know what you think about it, as long as we agree on the > patch I'll commit it. But I also agree with John that imposing large churn due to the elimination of the '__' prefix is too late now. At least it will make the change non-MFCable. Besides, we already lived with the names for 10+ years. I will be happy to have the part of the patch that exports the mtx_XXX_(mtx, file, line) defines which can be used without taking care of LOCK_DEBUG or MUTEX_NOINLINE in the consumer code. --oe1auVEEt6MAu8AG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iEYEARECAAYFAk7DeDYACgkQC3+MBN1Mb4gr7QCgir16eqHqqf829VLsmpLBDqa1 hyEAn2kqYVWuBBwiXtfYczpr0tvoWXyx =ydW+ -----END PGP SIGNATURE----- --oe1auVEEt6MAu8AG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111116084542.GY50300>