Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 07 Apr 2006 22:04:16 -0700
From:      Sam Leffler <sam@errno.com>
To:        frank@exit.com
Cc:        arch@freebsd.org
Subject:   Re: ifnet cloning changes
Message-ID:  <44374450.2070001@errno.com>
In-Reply-To: <1144469861.21943.13.camel@realtime.exit.com>
References:  <44370CD6.9090006@errno.com> <1144469861.21943.13.camel@realtime.exit.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Frank Mayhar wrote:
> On Fri, 2006-04-07 at 18:07 -0700, Sam Leffler wrote:
>> modifies the SIOCIFCREATE api in the kernel so that an opaque parameter 
>> block can be passed down to ifnet cloning routines (actually the user 
>> address is passed down and the caller must do the copyin since it alone 
>> knows the size of the parameter block).
> 
> Isn't that a recipe for potential breakage?  Why not make the api
> receive a vector, i.e. buffer/length?  The "caller" will know the actual
> layout of the parameter block but other kernel routines will at least be
> able to deal with it, since they'll know the size.

Feel free to provide an alternative implementation; I'm not wed to the code.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44374450.2070001>