Date: Fri, 19 Nov 2010 04:57:02 +0300 From: Anonymous <swell.k@gmail.com> To: Alexander Best <arundel@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: Re: [patch] reminding developers to check for duplicates in ObsoleteFiles.inc and tools/build/mk/OptionalObsoleteFiles.inc Message-ID: <8662vu3wk1.fsf@gmail.com> In-Reply-To: <86y68q3yaz.fsf@gmail.com> (Anonymous's message of "Fri, 19 Nov 2010 04:19:16 %2B0300") References: <20101118185837.GA44549@freebsd.org> <86y68q3yaz.fsf@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Anonymous <swell.k@gmail.com> writes:
> Alexander Best <arundel@freebsd.org> writes:
>
>> diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
>> index e358ed9..106c10e 100644
>> --- a/ObsoleteFiles.inc
>> +++ b/ObsoleteFiles.inc
>> @@ -13,6 +13,12 @@
>> #
>> # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last.
>> #
>> +# Before you commit changes to this file please check, if any entries in
>> +# tools/build/mk/OptionalObsoleteFiles.inc can be removed. The following
>> +# command was proposed by Dmitry Morozovsky:
>> +# ( grep '+=' /usr/src/ObsoleteFiles.inc | sort -u ; \
>> +# grep '+=' /usr/src/tools/build/mk/OptionalObsoleteFiles.inc | sort -u) | \
>> +# sort | uniq -d
>
> An easier way to check duplicates that understands `.if ${TARGET_ARCH}...'
>
> $ make -V OLD_FILES -V OLD_LIBS -V OLD_DIRS \
> -f Makefile.inc1 check-old \
> | sed 'y/ /\n/' | sort | uniq -d
Nevermind. It's more important to check OptionalObsoleteFiles.inc when
files are re-introduced and thus removed from ObsoleteFiles.inc.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8662vu3wk1.fsf>