Date: Thu, 5 Jun 2014 15:11:38 +0200 From: Marius Strobl <marius@alchemy.franken.de> To: Warner Losh <imp@bsdimp.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r263749 - in head: . sys/amd64/conf sys/conf sys/i386/conf sys/sparc64/conf Message-ID: <20140605131138.GG679@alchemy.franken.de> In-Reply-To: <B07EACC3-B543-4039-8124-517B159C6C79@bsdimp.com> References: <201403252208.s2PM8VXj019660@svn.freebsd.org> <201404071505.09468.jhb@freebsd.org> <B07EACC3-B543-4039-8124-517B159C6C79@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 07, 2014 at 03:12:34PM -0600, Warner Losh wrote: > > On Apr 7, 2014, at 1:05 PM, John Baldwin <jhb@freebsd.org> wrote: > > > On Tuesday, March 25, 2014 6:08:31 pm Warner Losh wrote: > >> Author: imp > >> Date: Tue Mar 25 22:08:31 2014 > >> New Revision: 263749 > >> URL: http://svnweb.freebsd.org/changeset/base/263749 > >> > >> Log: > >> Rather than require a makeoptions DEBUG to get debug correct, > >> add it in kern.mk, but only if we're using clang. While this > >> ... > >> Modified: head/sys/amd64/conf/GENERIC > >> ============================================================================== > >> --- head/sys/amd64/conf/GENERIC Tue Mar 25 21:57:50 2014 (r263748) > >> +++ head/sys/amd64/conf/GENERIC Tue Mar 25 22:08:31 2014 (r263749) > >> @@ -21,7 +21,7 @@ > >> cpu HAMMER > >> ident GENERIC > >> > >> -makeoptions DEBUG=-gdwarf-2 # Build kernel with gdb(1) debug symbols > >> +makeoptions DEBUG=-g > >> makeoptions WITH_CTF=1 # Run ctfconvert(1) for DTrace support > > > > Did you mean to lose this comment in all these files? > > No. I didn?t mean to loose it. Damn. Thanks! FYI, restoring these comments and then MFCing the whole thing - which would be great to have in 9.3-RELEASE - is still missing. Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140605131138.GG679>