Date: Wed, 19 Mar 2003 21:45:02 -0800 From: David Schultz <das@FreeBSD.org> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h Message-ID: <20030320054502.GA4308@HAL9000.homeunix.com> In-Reply-To: <20030320050712.GA48184@nagual.pp.ru> References: <200303192025.h2JKPjNr000550@repoman.freebsd.org> <20030320050712.GA48184@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Thus spake Andrey A. Chernov <ache@nagual.pp.ru>: > On Wed, Mar 19, 2003 at 12:25:45 -0800, David Schultz wrote: > > Log: > > Enable locale support in strtod() and dtoa(). > > > > Noticed by: ache > > Reviewed by: mike (mentor) > > It seems that locale implementation is not complete - see > gethex.c:gethex() '.' processing (must be actual decimal point here). The > fix is obvious (like in other places). Good catch. Fortunately nobody relies upon hexadecimal floating point constants at the moment. (Before I sent the vendor some patches, strtod() would actually core dump when it saw them!) Do you see anything else I should bug the vendor about while I'm at it? As you can tell, I don't often use anything other than the C locale. I think we're the first to integrate a modern version of David Gay's library into a full-blown operating system, so we get to stumble across all the nits. :( > The next thing is style: why > #include "locale.h" > instead of > #include <locale.h> ? With one exception, the author uses that convention consistently. I imagine it would be convenient if an integrator wanted to override one of the standard system headers. Whatever his reason may be, it shouldn't hurt anything. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030320054502.GA4308>