Date: Tue, 4 Dec 2007 12:00:57 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Olivier Houchard <cognet@freebsd.org>, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen closedir.c Message-ID: <20071204115427.D3192@delplex.bde.org> In-Reply-To: <868x4beu46.fsf@ds4.des.no> References: <200711192157.lAJLvSu6057416@repoman.freebsd.org> <868x4beu46.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-641280724-1196730057=:3192 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 3 Dec 2007, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote: > Olivier Houchard <cognet@FreeBSD.org> writes: >> Log: >> Change the casts from (pthread_mutex_t *) to (void *) to keep gcc quie= t. >> Anybody with a cleaner solution feel free to change it. > > Declare dd_lock as a struct pthread_mutex * instead of a void * in > src/include/dirent.h. dd_lock cannot be declared as struct pthread_mutex *, since pthread_mutex is not permitted in the application namespace of dirent.h. dirent.h is (was) careful about namespaces. E.g., it keeps out of the application namespace for its own struct _dirdesc. This doesn't work for pthread_mutex since that is misdesigned. (I think pthread_mutex_t is supposed to hide the implementation and reduce namespace problems, but struct pthread was only declared in <pthread.h> where it is permitted in the namespace, so <pthread.h> doesn't bother naming it struct _pthread_mutex. Other headers can't define it with a different name (tag) because different tags give different structs.) Bruce --0-641280724-1196730057=:3192--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071204115427.D3192>