Date: Mon, 02 Jun 2003 21:25:00 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c Message-ID: <14255.1054581900@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 02 Jun 2003 15:23:10 EDT." <XFMail.20030602152310.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <XFMail.20030602152310.jhb@FreeBSD.org>, John Baldwin writes: > >On 31-May-2003 Poul-Henning Kamp wrote: >> phk 2003/05/31 13:09:42 PDT >> >> FreeBSD src repository >> >> Modified files: >> sys/kern subr_witness.c >> Log: >> Remove return after panic. >> >> Found by: FlexeLint > >revision 1.90 >date: 2001/11/15 19:46:36; author: jhb; state: Exp; lines: +7 -3 >Add a couple of returns to making recovering from a failed witness_assert() >more sane in the RESTARTABLE_PANICS case. > >They were intentional, though perhaps they should have been wrapped >in #ifdef RESTARTABLE_PANICS. cvs annotate is your friend. :) That would be the correct solution. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?14255.1054581900>