Date: Wed, 16 May 2007 09:43:30 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Dag-Erling =?utf-8?b?U23Dg8K4cmdyYXY=?= <des@des.no> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <20070516094330.dkp2e41vdc0w8kg8@webmail.leidinger.net> In-Reply-To: <861whiy5ra.fsf@dwp.des.no> References: <200705131815.l4DIFop9026874@repoman.freebsd.org> <20070514154040.0lofzrgm8kskgog4@webmail.leidinger.net> <86wszbqxbz.fsf@dwp.des.no> <20070514172938.5v4yi78kisokk84s@webmail.leidinger.net> <861whiy5ra.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Dag-Erling Sm=C3=83=C2=B8rgrav <des@des.no> (from Tue, 15 May 2007 =
=20
08:12:41 +0200):
> Alexander Leidinger <Alexander@Leidinger.net> writes:
>> Dag-Erling Smorgrav <des@FreeBSD.org> writes:
>> > Alexander Leidinger <Alexander@Leidinger.net> writes:
>> > > Why did you remove the echo?
>> > which echo? about schg? it was completely bogus.
>> Yes. I don't think so, please explain.
>
> It would show up incorrectly if you declined to remove a file.
>
>> > feel free to re-add it, but only if you also add logic to check whether
>> > the file actually has the schg flag set before running chflags.
>> In the current code it doesn't make sense, and the wording can be
>> changed to tell that it will remove schg, in case this flag is set. As
>> you did the change and I don't have time to commit such a change when
>> I'm back at home (the place where I can make commits), would you
>> please add the echo again?
>
> That would mean an extra line of output for every single file...
What about another idea: removing the chflags all together and let the =20
removal fail (with a message that the file may be protected with schg =20
and it should be removed with chglags). This way only a message =20
appears when the rm fails (saying no to the removal question of rm is =20
not a failure/exit!=3D0).
>> > > - bug(?): ${DESTDIR} in the rm line
>> > no, this is intentional, and in fact the original code had it too.
>> The original code hat it before, but you CD into DESTDIR, so it is not
>> necessary anymore.
>
> Unless someone goofs and adds an absolute path to ObsoleteFiles.inc...
> which is why I very deliberately left "${DESTDIR}/" in front of the path
> in the rm command, although I could probably replace it with "./".
That would make it more consistent.
Bye,
Alexander.
--=20
War doesn't prove who's right, just who's left.
http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070516094330.dkp2e41vdc0w8kg8>