Date: Wed, 29 Nov 2006 00:12:47 +0100 From: Henrik Brix Andersen <henrik@brixandersen.dk> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Florent Thoumie <flz@FreeBSD.org> Subject: Re: cvs commit: src/sys/dev/usb ukbd.c usb_quirks.c usb_quirks.h usbdevs Message-ID: <20061128231247.GB73497@tirith.brixandersen.dk> In-Reply-To: <20061128224915.GA38469@rambler-co.ru> References: <200611282113.kASLD8vu090754@repoman.freebsd.org> <20061128220111.GA71168@tirith.brixandersen.dk> <20061128220529.GA38107@rambler-co.ru> <20061128222641.GA73497@tirith.brixandersen.dk> <20061128224915.GA38469@rambler-co.ru>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Nov 29, 2006 at 01:49:15AM +0300, Ruslan Ermilov wrote: > On Tue, Nov 28, 2006 at 11:26:41PM +0100, Henrik Brix Andersen wrote: > > On Wed, Nov 29, 2006 at 01:05:29AM +0300, Ruslan Ermilov wrote: > > > Why can't you just check for the defined constant? > > > > To clarify: it is a run-time issue, not a compile-time issue. The > > application will compile fine regardless of the above patch, but > > without the above patch (and with ukbd/uhid loaded) the application > > will fail to attach to the device. > > > You want to build a port only when you know that the kernel has > this fix? That is my intention, yes. Otherwise end-users will likely be confused as to why the application fails to detect their device. Regards, Brix -- Henrik Brix Andersen <henrik@brixandersen.dk> [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) Comment: GnuPG signed iD8DBQFFbMJvv+Q4flTiePgRApBoAKCD7fjKsVFHaGvwLJX92AruNvyHHACfUChw 7i1Zk4K7Cp4vJ2nOstJP5CU= =86uj -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061128231247.GB73497>