Date: Thu, 17 Jan 2013 08:35:41 +0000 (UTC) From: Lawrence Stewart <lstewart@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r245543 - projects/diffused_head/sbin/ipfw/diffuse_collector Message-ID: <201301170835.r0H8ZfCD067185@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: lstewart Date: Thu Jan 17 08:35:41 2013 New Revision: 245543 URL: http://svnweb.freebsd.org/changeset/base/245543 Log: Mitigate against possible unaligned access when serialising data into a buffer. Reported by: clang Modified: projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c Modified: projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c ============================================================================== --- projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c Thu Jan 17 07:04:37 2013 (r245542) +++ projects/diffused_head/sbin/ipfw/diffuse_collector/diffuse_collector.c Thu Jan 17 08:35:41 2013 (r245543) @@ -1894,8 +1894,7 @@ request_classifier_state() thdr->flags = 0; offs += sizeof(struct dip_templ_header); - *((uint16_t *)(reqstatepkt + offs)) = - htons(dip_info[DIP_IE_MSG_TYPE].id); + be16enc(reqstatepkt + offs, htons(dip_info[DIP_IE_MSG_TYPE].id)); offs += sizeof(uint16_t); shdr->set_len = htons(offs - sizeof(struct dip_header));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201301170835.r0H8ZfCD067185>