Date: Wed, 25 Apr 2001 18:41:33 -0700 From: Peter Wemm <peter@wemm.org> To: Alfred Perlstein <bright@wintelcom.net> Cc: Terry Lambert <tlambert@primenet.com>, current@FreeBSD.ORG, terry@lambert.org Subject: Re: PATCH to make maxfiles, maxfiles per proc boot-time tunable Message-ID: <20010426014133.50363380A@overcee.netplex.com.au> In-Reply-To: <20010424122508.U1790@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein wrote: > * Terry Lambert <tlambert@primenet.com> [010424 11:59] wrote: > > It seems to me that these things are not boot-time tunable, and > > should be (really, they should be runtime tunable, but there > > are some nasty pageable region allocations for networking that > > appear to require contiguous regions for no good reason which I > > can discern). That means that the best we can do right now is > > boot-time, so here it is: > > This looks good except that ncallout is still based on MAXFILES, > without this being fixed I think people might get bitten by > raising the tuneable too high then being unable to allocate > enough callouts. Can you take a look at this and make sure there's > nothing else using MAXFILES like that? The problem is that param.c is *not* included in gensetdefs scope. Therefore linker set entries (ie: SYSINIT etc) are not executed. TUNABLE* entries in param.c are simply not called or used. SYSTEM_OBJS= locore.o setdef0.o vnode_if.o ${OBJS} ioconf.o param.o config.o \ setdef1.o hack.So ... setdef0.c setdef1.c setdefs.h: ${OBJS} @gensetdefs ${OBJS} param.o is not included in ${OBJS}. I dont see how this patch can work as-is. Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010426014133.50363380A>