Date: Thu, 19 Feb 2009 16:30:11 +0000 (UTC) From: Warner Losh <imp@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/usr.sbin/rtadvd rrenum.c Message-ID: <200902191630.n1JGUH7s078143@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2009-02-19 16:30:11 UTC
FreeBSD src repository
Modified files:
usr.sbin/rtadvd rrenum.c
Log:
SVN rev 188820 on 2009-02-19 16:30:11Z by imp
Properly convert bit value to a bit field. Before we were storing
values like 0x80 or 0x40 into a uint8_t foo:1 bitfield. This would
result in the bit always being 0. One of these caused a warning for
overflow (one that was 0x80), but the other didn't. They were both
wrong.
This is why I hate code that mixes c struct bitfields and #defines.
The rest of the fields accessed by the program should be audited.
Revision Changes Path
1.10 +2 -2 src/usr.sbin/rtadvd/rrenum.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902191630.n1JGUH7s078143>