Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 07 Aug 2020 07:34:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 248377] [PATCH] script(1): Enable proper playback [-p] of curses sessions
Message-ID:  <bug-248377-227-v5XzjuQnUN@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-248377-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-248377-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248377

SOUMENDRA GANGULY <0.gangzta@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #216973|0                           |1
        is obsolete|                            |

--- Comment #9 from SOUMENDRA GANGULY <0.gangzta@gmail.com> ---
Created attachment 217063
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=217063&action=edit
script.diff

Adds elegant error handling. For example, instead of using isatty followed by
tcgetattr, tcgetattr is directly used. This is logical because
freebsd/lib/libc/gen/isatty.c suggests that isatty is actually implemented
using tcgetattr. Upon failure of tcgetattr, errno is checked to decide if
stdout is a tty. 

Note: I am comfortable with Bugzilla now. Therefore, I am closing the GitHub
pull request.

-- 
You are receiving this mail because:
You are the assignee for the bug.

help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248377-227-v5XzjuQnUN>