Date: Sun, 24 Jun 2001 22:43:25 -0700 From: Dima Dorfman <dima@unixfreak.org> To: Mike Barcroft <mike@q9media.com> Cc: audit@FreeBSD.org Subject: Re: src/usr.sbin/spray patch Message-ID: <20010625054325.22A633E28@bazooka.unixfreak.org> In-Reply-To: <200106250544.f5P5iQR91718@coffee.q9media.com>; from mike@q9media.com on "Mon, 25 Jun 2001 01:44:26 -0400 (EDT)"
next in thread | previous in thread | raw e-mail | index | archive | help
Mike Barcroft <mike@q9media.com> writes:
> @@ -186,11 +187,8 @@
> }
>
>
> -void
> -print_xferstats(packets, packetlen, xfertime)
> - int packets;
> - int packetlen;
> - double xfertime;
> +static void
> +print_xferstats(int packets, int packetlen, double xfertime)
> {
> int datalen;
> double pps; /* packets per second */
> @@ -212,7 +210,7 @@
>
>
> static void
> -usage ()
> +usage(void)
> {
If you're going to ANSIify these, you might as well ANSIify the rest
(i.e., main). As Warner (imp@) said to me once, "The one thing worse
than old K&R code in the tree is broken K&R code in the tree."
Dima Dorfman
dima@unixfreak.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010625054325.22A633E28>