Skip site navigation (1)Skip section navigation (2) 
Date:      Tue, 19 May 2026 14:57:41 +0000
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 61c9f9b482ca - stable/14 - tcp: cleanup
Message-ID:  <6a0c7a65.3ef58.a5e5f45@gitrepo.freebsd.org>
index | next in thread | raw e-mail 

The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=61c9f9b482ca927d3da668f73f434474cd835e31

commit 61c9f9b482ca927d3da668f73f434474cd835e31
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2026-02-22 17:44:10 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2026-05-19 12:56:53 +0000

    tcp: cleanup
    
    No functional change intended.
    
    Reviewed by:            pouria, rrs, Timo Völker
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D55415
    
    (cherry picked from commit c984c7593e11aa95f21f79bb5425a9d5e9181945)
---
 sys/netinet/tcp_subr.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/sys/netinet/tcp_subr.c b/sys/netinet/tcp_subr.c
index ca201d721616..31f52cbebffa 100644
--- a/sys/netinet/tcp_subr.c
+++ b/sys/netinet/tcp_subr.c
@@ -633,13 +633,14 @@ tcp_recv_udp_tunneled_packet(struct mbuf *m, int off, struct inpcb *inp,
 	if ((m->m_flags & M_PKTHDR) == 0) {
 		/* Can't handle one that is not a pkt hdr */
 		TCPSTAT_INC(tcps_tunneled_errs);
-		goto out;
+		m_freem(m);
+		return (true);
 	}
 	thlen = sizeof(struct tcphdr);
 	if (m->m_len < off + sizeof(struct udphdr) + thlen &&
 	    (m =  m_pullup(m, off + sizeof(struct udphdr) + thlen)) == NULL) {
 		TCPSTAT_INC(tcps_tunneled_errs);
-		goto out;
+		return (true);
 	}
 	iph = mtod(m, struct ip *);
 	uh = (struct udphdr *)((caddr_t)iph + off);
@@ -649,7 +650,7 @@ tcp_recv_udp_tunneled_packet(struct mbuf *m, int off, struct inpcb *inp,
 		m =  m_pullup(m, off + sizeof(struct udphdr) + thlen);
 		if (m == NULL) {
 			TCPSTAT_INC(tcps_tunneled_errs);
-			goto out;
+			return (true);
 		} else {
 			iph = mtod(m, struct ip *);
 			uh = (struct udphdr *)((caddr_t)iph + off);
@@ -671,9 +672,10 @@ tcp_recv_udp_tunneled_packet(struct mbuf *m, int off, struct inpcb *inp,
 #ifdef INET
 	case IPVERSION:
 		len = ntohs(iph->ip_len) - sizeof(struct udphdr);
-		if (len != m->m_pkthdr.len) {
+		if (__predict_false(len != m->m_pkthdr.len)) {
 			TCPSTAT_INC(tcps_tunneled_errs);
-			goto out;
+			m_freem(m);
+			return (true);
 		} else {
 			iph->ip_len = htons(len);
 			tcp_input_with_port(&m, &off, IPPROTO_TCP, port);
@@ -684,9 +686,11 @@ tcp_recv_udp_tunneled_packet(struct mbuf *m, int off, struct inpcb *inp,
 	case IPV6_VERSION >> 4:
 		ip6 = mtod(m, struct ip6_hdr *);
 		len = ntohs(ip6->ip6_plen) - sizeof(struct udphdr);
-		if (len + sizeof(struct ip6_hdr) != m->m_pkthdr.len) {
+		if (__predict_false(len + sizeof(struct ip6_hdr) !=
+		    m->m_pkthdr.len)) {
 			TCPSTAT_INC(tcps_tunneled_errs);
-			goto out;
+			m_freem(m);
+			return (true);
 		} else {
 			ip6->ip6_plen = htons(len);
 			tcp6_input_with_port(&m, &off, IPPROTO_TCP, port);
@@ -694,13 +698,9 @@ tcp_recv_udp_tunneled_packet(struct mbuf *m, int off, struct inpcb *inp,
 		break;
 #endif
 	default:
-		goto out;
+		m_freem(m);
 		break;
 	}
-	return (true);
-out:
-	m_freem(m);
-
 	return (true);
 }
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a0c7a65.3ef58.a5e5f45>