Date: Wed, 19 Jun 2013 08:02:46 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Alfred Perlstein <bright@mu.org> Cc: freebsd-hackers@freebsd.org Subject: Re: please review, patch for lost camisr Message-ID: <20130619050246.GB91021@kib.kiev.ua> In-Reply-To: <20130529071645.GR3047@kib.kiev.ua> References: <51A44B0C.8010908@ixsystems.com> <201305281204.14146.jhb@freebsd.org> <51A505A5.7030105@ixsystems.com> <201305281613.32414.jhb@freebsd.org> <51A514F5.9050405@ixsystems.com> <20130529050835.GP3047@kib.kiev.ua> <51A592BC.1050100@mu.org> <20130529071645.GR3047@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--SuZWD+5recMkC1v4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, May 29, 2013 at 10:16:45AM +0300, Konstantin Belousov wrote:
> Well, if you and I are right, the minimal patch should be
>=20
> diff --git a/sys/kern/kern_intr.c b/sys/kern/kern_intr.c
> index 8d63c9b..7c21015 100644
> --- a/sys/kern/kern_intr.c
> +++ b/sys/kern/kern_intr.c
> @@ -1349,7 +1349,7 @@ ithread_loop(void *arg)
> * we are running, it will set it_need to note that we
> * should make another pass.
> */
> - while (ithd->it_need) {
> + while (atomic_load_acq_int(&ithd->it_need)) {
> /*
> * This might need a full read and write barrier
> * to make sure that this write posts before any
>=20
So, was it tested ? If yes, did the patch helped ?
--SuZWD+5recMkC1v4
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)
iQIcBAEBAgAGBQJRwTt1AAoJEJDCuSvBvK1B+AEQAIlcj0WnzAtd9xL4YaZbwWLa
FLm9+klP5D4KBVU5rRP+6TQo+rfRJVjaoHo31KaxYcLhUlTdYTkHFAF0WZqdbovO
AJ17mITHNlokdQWMOybXVIw5J5OnS1MejdcCASvLqA3gsgdkQRI3reaf4q5HjN8O
fsXKk45V1Y60PlE0ptwZvwSKZ2MR0MxZlrrqyFLMOqhiUJfVJdsXLDgHx0NzXhVU
hkxb4dq/+i6cEWoMyOdyVTcf5bI4eDwrPBFLLQ4rja+61kTKLMXkyTgopUXHtBdw
Rse+VWsyLcM2XG3S//AMX+iBo1E0DU1PFjIPum1UeFJnsX9HeXAoiAA2GTSpZyLG
obbpknZwnB6si/oBXDByveeipgzlEgBsy6acFK+CPaQN7vExMqJVlHIqxytXV33o
svtQCglP2APoYmhZPYR5DW3av6+Gj/PsIEeDpM/gMUHOHRVBgKGmN9tvzs75j/aV
mX0CJ+GwMu7xmbeDujlyneMcwowefaOOXdnyaTycbB7oGw12DKo0aZrR1nQoKGDU
A81IRD+1hT22yRMx6M+RG/pNk8w9Mvqww8Qvo0IwKXRUlh+NAsyzFegFDzFZTXJF
gwedIfwXm9JDvaHr0/Urwwq52fDCUPYLShEqKNeGVYi2vYBUGmkJRSa6IdsIMC1n
j8GG1NXm57fvTaqQ7g7o
=tFfw
-----END PGP SIGNATURE-----
--SuZWD+5recMkC1v4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130619050246.GB91021>