Date: Thu, 8 Feb 2001 20:18:09 +0300 (MSK) From: m_ilya@agava.com To: FreeBSD-gnats-submit@freebsd.org Subject: kern/24954: Old driver /src/sys/dev/sound/isa/sb.c should be removed in STABLE4? Message-ID: <20010208171809.0783724A@juil.domain>
next in thread | raw e-mail | index | archive | help
>Number: 24954 >Category: kern >Synopsis: Old driver /src/sys/dev/sound/isa/sb.c should be removed in STABLE4? >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Feb 08 09:20:02 PST 2001 >Closed-Date: >Last-Modified: >Originator: Ilya Martynov >Release: FreeBSD 4.2-STABLE i386 >Organization: AGAVA Software >Environment: N/A >Description: I've tried to compile port audio/aureal-kmod. I've found that I can't load produced kernel module. In log I can see message 'link_elf: symbol chn_allocbuf undefined'. After greping sources of aureal-kmod and kernel I found that the only place where 'chn_allocbuf' function is used is in /src/sys/dev/sound/isa/sb.c. I've discovered that it seems to use some old API that doesn't exists anymore. After comparing sources of other drivers I've came up with following patch: --- sb.c~ Thu Oct 5 09:07:49 2000 +++ sb.c Thu Feb 8 19:55:48 2001 @@ -672,8 +672,8 @@ ch->parent = sb; ch->channel = c; ch->buffer = b; - ch->buffer->bufsize = DSP_BUFFSIZE; - if (chn_allocbuf(ch->buffer, sb->parent_dmat) == -1) + + if (sndbuf_alloc(ch->buffer, sb->parent_dmat, DSP_BUFFSIZE) == -1) return NULL; dch = (dir == PCMDIR_PLAY)? 1 : 0; if (sb->bd_flags & BD_F_SB16X) But later I've looked in FreeBSD cvs and found that this file is actually deleted from CURRENT becouse it is outdated. So I have suspicion that this file should be just deleted from STABLE also instead patching. >How-To-Repeat: See Description. >Fix: See Description. >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010208171809.0783724A>