Date: Fri, 17 Aug 2018 16:01:44 +0300 From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336439 - in head: share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe/crypto sys/dev/hifn sys/dev/safe sys/dev/s... Message-ID: <6d1d2b23-978b-af1d-4022-16d09c9a42f5@yandex.ru> In-Reply-To: <201807180056.w6I0uPb6000705@repo.freebsd.org> References: <201807180056.w6I0uPb6000705@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KFC0c0PSk2x6icLevvyZ2vluPp8N6284P Content-Type: multipart/mixed; boundary="u4g29DgrNyLAd17BAj5hVtDf4awq8uScG"; protected-headers="v1" From: "Andrey V. Elsukov" <bu7cher@yandex.ru> To: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <6d1d2b23-978b-af1d-4022-16d09c9a42f5@yandex.ru> Subject: Re: svn commit: r336439 - in head: share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe/crypto sys/dev/hifn sys/dev/safe sys/dev/s... References: <201807180056.w6I0uPb6000705@repo.freebsd.org> In-Reply-To: <201807180056.w6I0uPb6000705@repo.freebsd.org> --u4g29DgrNyLAd17BAj5hVtDf4awq8uScG Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 18.07.2018 03:56, Conrad Meyer wrote: > Author: cem > Date: Wed Jul 18 00:56:25 2018 > New Revision: 336439 > URL: https://svnweb.freebsd.org/changeset/base/336439 >=20 > Log: > OpenCrypto: Convert sessions to opaque handles instead of integers > =20 > Track session objects in the framework, and pass handles between the > framework (OCF), consumers, and drivers. Avoid redundancy and comple= xity in > individual drivers by allocating session memory in the framework and > providing it to drivers in ::newsession(). Hi, this produces WITNESS warning, since crypto_newsession() allocates memory with M_WAITOK flag while xform_init() holds mutex: uma_zalloc_arg: zone "crypto_session" with the following non-sleepable locks held: exclusive sleep mutex xforms_list (IPsec transforms list) r =3D 0 (0xffffffff81fdb840) locked @ /home/devel/freebsd/base/head/sys/netipsec/key.c:8676 stack backtrace: #0 0xffffffff80c01643 at witness_debugger+0x73 #1 0xffffffff80c02a21 at witness_warn+0x461 #2 0xffffffff80ed98a8 at uma_zalloc_arg+0x38 #3 0xffffffff80e4a0ca at crypto_newsession+0x1ea #4 0xffffffff80e3994c at esp_init+0x37c #5 0xffffffff80e31e68 at key_setsaval+0x7f8 #6 0xffffffff80e307e2 at key_newsav+0x302 #7 0xffffffff80e2ba0d at key_add+0x53d #8 0xffffffff80e263f5 at key_parse+0xac5 #9 0xffffffff80c34dc7 at sosend_generic+0x447 #10 0xffffffff80c34ffd at sosend+0x6d #11 0xffffffff80c3c170 at kern_sendit+0x240 #12 0xffffffff80c3c4be at sendit+0x19e #13 0xffffffff80c3c30d at sys_sendto+0x4d #14 0xffffffff8107e9c1 at amd64_syscall+0x281 #15 0xffffffff8105846d at fast_syscall_common+0x101 --=20 WBR, Andrey V. Elsukov --u4g29DgrNyLAd17BAj5hVtDf4awq8uScG-- --KFC0c0PSk2x6icLevvyZ2vluPp8N6284P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQEzBAEBCAAdFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAlt2xzgACgkQAcXqBBDI oXrITwgAu8htJSVZzcZGwl4kyWQduUDj8Pudl+Fdy7QB+AcTM/IZ7H2nnUpoRT9M 7Z8wqoX0dkVZSXBMm4CYGM61/flWzxToKa2e2+gxKFuQV+Ln/yr5RAtfMlpzwQRM IoPqfiC2BOuwXANPm/8MUPEhHvqb5wxSwxI1RA2l+GvYOy+U/CotMyjtJyyLnLTv MF9AjZhxf4oqx1MOy+jB/EvNhAb9th2yKxc3XdkpDN8BfuGwuyA44LOMcSrlSxug +pgTmfvF1axfcgoyuM1SDKpNIfH0D1AbmPoh3XOC238H9tNy7r6XRFYbNH6zfGhT 8nUlEhY36L5vHSE8TlkxHL2ZPa+TQA== =rUKY -----END PGP SIGNATURE----- --KFC0c0PSk2x6icLevvyZ2vluPp8N6284P--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6d1d2b23-978b-af1d-4022-16d09c9a42f5>