Date: Mon, 26 May 2008 18:18:13 +0200 From: Henrik Brix Andersen <brix@FreeBSD.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils Makefile ports/sysutils/conky Makefile ports/sysutils/conky-awesome Makefile pkg-descr ports/sysutils/conky-awesome/files patch-src_conky.c Message-ID: <20080526161813.GA72695@tirith.brixandersen.dk> In-Reply-To: <1211754054.69646.13.camel@shumai.marcuscom.com> References: <200805251720.m4PHKtRD026886@repoman.freebsd.org> <20080525215334.GA66430@tirith.brixandersen.dk> <1211754054.69646.13.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, May 25, 2008 at 06:20:54PM -0400, Joe Marcus Clarke wrote: > On Sun, 2008-05-25 at 23:53 +0200, Henrik Brix Andersen wrote: > > On Sun, May 25, 2008 at 05:20:55PM +0000, Joe Marcus Clarke wrote: > > > marcus 2008-05-25 17:20:54 UTC > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > sysutils Makefile > > > sysutils/conky Makefile > > > sysutils/conky-awesome Makefile pkg-descr > > > Added files: > > > sysutils/conky-awesome/files patch-src_conky.c > > > Log: > > > Add sysutils/conky-awesome after a repocopy from sysutils/conky. > > > Conky-awesome is the conky X-based system monitor ported to the awesome > > > window manager. > > > > > > Submitted by: adamw > > > Conky diffs approved by: novel > > > > Does this really warrant a port of its own? Couldn't it just be a KNOB > > in sysutils/conky? > > This kind of changes (requiring new patches and a new pkg-descr) Patches? The only patch I see is this one-liner, which adds an extra line break to a printf() argument? http://www.freebsd.org/cgi/cvsweb.cgi/ports/sysutils/conky-awesome/files/patch-src_conky.c?rev=1.1&content-type=text/plain That seems simple enough to be included in the regular conky port? (Why is that patch even needed for 'awesome'?) Brix -- Henrik Brix Andersen <brix@FreeBSD.org> [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) Comment: GnuPG signed iEYEARECAAYFAkg64sUACgkQv+Q4flTiePjCiACeMl4wAgwYeKGQyixkXaGIk0f5 ZNAAnjfzdPNpmldtu5J4ShIGWmmnFIJE =65nc -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080526161813.GA72695>