Date: Thu, 20 Mar 2003 09:13:16 +0300 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h Message-ID: <20030320061316.GA48935@nagual.pp.ru> In-Reply-To: <20030320054502.GA4308@HAL9000.homeunix.com> References: <200303192025.h2JKPjNr000550@repoman.freebsd.org> <20030320050712.GA48184@nagual.pp.ru> <20030320054502.GA4308@HAL9000.homeunix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote:
> Do you see anything else I should bug the vendor about while I'm at
> it?
So far I notice one thing only:
char decimalpoint = *localeconv()->decimal_point;
... and then decimalpoint used everywhere in the code.
But localeconv() can return "" for any value which is legally not in the
current locale. decimalpoint becomes '\0' in that case which cause
unwanted effects. So there always must be added fallback code something
like:
if (decimalpoint == '\0')
decimalpoint = '.';
in all places after localeconv() called.
> > The next thing is style: why
> > #include "locale.h"
> > instead of
> > #include <locale.h> ?
>
> With one exception, the author uses that convention consistently.
I don't think so - I saw <stdio.h>, <string.h> in the author's code. It
may affect cross-platform building when standard includes moved to other
place and gcc instructed to find them there.
--
Andrey A. Chernov
http://ache.pp.ru/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030320061316.GA48935>