Date: Sat, 5 Dec 2015 12:58:28 -0700 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: Benjamin Kaduk <bjkfbsd@gmail.com>, Warner Losh <imp@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r291860 - in head/tools/tools/nanobsd: . embedded Message-ID: <BEC52493-9862-4999-88E5-0E2379FDAF80@bsdimp.com> In-Reply-To: <6A5C1B44-49E2-4E61-B915-B2424A96F574@gmail.com> References: <201512051628.tB5GSEnr024370@repo.freebsd.org> <CAJ5_RoBhMb1UBqaSbzShT7Qw7hNhjQQuSusdWOL_7QWdgd3O1g@mail.gmail.com> <6A5C1B44-49E2-4E61-B915-B2424A96F574@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Dec 5, 2015, at 11:09 AM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
>
>
> On Dec 5, 2015, at 09:26, Benjamin Kaduk <bjkfbsd@gmail.com> wrote:
>
> ...
>
>> - [ ! -z "${NANO_NOPRIV_BUILD" ] && [ -z "${NANO_METALOG}"] && \
>> + [ ! -z "${NANO_NOPRIV_BUILD}" ] && [ -z "${NANO_METALOG}"] && \
>>
>> Hmm, is there still a missing space between '"' and ']' in the second clause?
>
> Yup. Still broken, but at least it won't die immediate due to a syntax error like it would have before this commit.
Fixed in a second commit. And more cleanup of setting variables like this
are coming thanks to some hints from elsewhere.
Warner
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJWY0HlAAoJEGwc0Sh9sBEAwBkP/3Qwzbzf4UiZgZOmx14muMcd
Jxa2z0QT+hT2wYxRe69SV/55B97CPfIy1R0Y6ZBcAkWgPUkHrk8UF6z4JdszaosM
/zikBgeUtsnCH3lGpuX05NA+7Ha9PCUPCEj6mNTB0M4Q8+zcZFTots91xXuCmNHx
sNtDexgx1QpFlHSBp3HUwsTz1rq6E7Q274o1OBRM7sL0FsSdApOceBE+dfJeDEn9
WNbMsnCejsg68vEzRwYfPd2PLJSw75KCtGbBd0BAPYLURoSdGVVabw4mEZuQO1aq
9QkHXg+yCVyuYYjlcJ2FScQpO3FpIk3MzZgaPiBsucGBHZXCsfVMDLW871Hi/KE9
d63HcuyHtGs6a4WreeXbcvcTCeVx+J/hcUoen8UKmlKkJCgDMvaKShaFrcNmYIRG
R4mdvcwyio8Bq5lmxeeoc5P9aEMh8L8xetTdeyO5HCeeF8wfeERSDLeitnJbpii8
8WQwOL4WCuWXpKWpoO7MQIDc5IL/B2XRz7MrdE0zlz1zA9ciio9NpcU0idz5JnPl
FTAbJ5FctHPKd4AY0JxGWQy3f7nTL202I7GVX4Xn6BHjtg7YNOpWWdjwnWrrI/NR
/JrRuDW+AuEdtHbX+jESG+TjwD55wODRqm2YbjIWXwcoT2wqVrE5wn3un8qO+tSk
cKrzs9Z05wRGIMg0jcfo
=7hZl
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BEC52493-9862-4999-88E5-0E2379FDAF80>