Date: Sun, 25 Dec 2016 16:46:11 +0100 From: "Felix J. Ogrs" <fjo-lists@ogris.de> To: perl@FreeBSD.org Subject: graphics/p5-GD doesn't detect libgd > 2.0.33 Message-ID: <5699f3bc-f5e7-9a3b-5474-fb5b1322c42f@ogris.de>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------DFA3CE7D5CE0BCDF33A1BDF3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi, both Build.PL and Makefile.PL of p5-GD-2.56 do not correctly parse the version of libgd as returned by gdlib-config. Excerpt from Makefile.PL line 302: my ($minor) = $version =~ /^2\.\d+\.(\d+)$/; $$options .= " GD_UNCLOSEDPOLY GD_ANIMGIF GD_FTCIRCLE VERSION_33" if defined($minor) && $minor >= 33; The above options GD_* were introduced as of libgd 2.0.33. But, current version is 2.2.3. Thus, the check fails. I'm proposing a trivial fix: my ($release, $major, $minor) = $version =~ /^(\d+)\.(\d+)\.(\d+)$/; $$options .= " GD_UNCLOSEDPOLY GD_ANIMGIF GD_FTCIRCLE VERSION_33" if defined($minor) && ($release > 2 || ($release == 2 && $major > 0) || ($release == 2 && $major == 0 && $minor >= 33)); Patches are attached. BR, Felix --------------DFA3CE7D5CE0BCDF33A1BDF3 Content-Type: text/plain; charset=UTF-8; name="patch-Build.PL.1" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch-Build.PL.1" LS0tIEJ1aWxkLlBMLm9yaWcJMjAxNi0xMi0xMyAyMDoyMjozMC4zNDg1NTAwMDAgKzAxMDAK KysrIEJ1aWxkLlBMCTIwMTYtMTItMTMgMjA6MjM6MDEuODIwOTU1MDAwICswMTAwCkBAIC0y ODAsOCArMjgwLDggQEAKICAgKCQkbGliX2dkX3BhdGggPSAkbGliZGlyKSA9fiBzIS9bXi9d KyQhITsKICAgJCRvcHRpb25zICAgICAgPSAkZmVhdHVyZXM7CiAKLSAgbXkgKCRtaW5vcikg ICAgPSAkdmVyc2lvbiA9fiAvXjJcLlxkK1wuKFxkKykkLzsKLSAgJCRvcHRpb25zICAgICAu PSAiIEdEX1VOQ0xPU0VEUE9MWSBHRF9BTklNR0lGIEdEX0ZUQ0lSQ0xFIFZFUlNJT05fMzMi IGlmIGRlZmluZWQoJG1pbm9yKSAmJiAkbWlub3IgPj0gMzM7CisgIG15ICgkcmVsZWFzZSwg JG1ham9yLCAkbWlub3IpID0gJHZlcnNpb24gPX4gL14oXGQrKVwuKFxkKylcLihcZCspJC87 CisgICQkb3B0aW9ucyAgICAgICAgICAgICAgICAgICAgLj0gIiBHRF9VTkNMT1NFRFBPTFkg R0RfQU5JTUdJRiBHRF9GVENJUkNMRSBWRVJTSU9OXzMzIiBpZiBkZWZpbmVkKCRtaW5vcikg JiYgKCRyZWxlYXNlID4gMiB8fCAoJHJlbGVhc2UgPT0gMiAmJiAkbWFqb3IgPiAwKSB8fCAo JHJlbGVhc2UgPT0gMiAmJiAkbWFqb3IgPT0gMCAmJiAkbWlub3IgPj0gMzMpKTsKIAogICBt eSBAY29ycmVjdF9pbmMgPSBtYXAge3MvXi1JLy8gJiYgJF99IHNwbGl0IC9ccysvLCRjZmxh Z3M7CiAgIGNoZWNrX2Zvcl9zdHJheV9oZWFkZXJzKCRpbmNsdWRlZGlyLEBjb3JyZWN0X2lu Yyk7Cg== --------------DFA3CE7D5CE0BCDF33A1BDF3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5699f3bc-f5e7-9a3b-5474-fb5b1322c42f>