Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jul 2001 10:33:42 -0700 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        "David E. O'Brien" <obrien@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   RE: cvs commit: src/usr.sbin/newsyslog Makefile newsyslog.c
Message-ID:  <XFMail.010730103342.jhb@FreeBSD.org>
In-Reply-To: <200107301541.f6UFfLQ59594@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 30-Jul-01 David E. O'Brien wrote:
> obrien      2001/07/30 08:41:20 PDT
> 
>   Modified files:
>     usr.sbin/newsyslog   Makefile newsyslog.c 
>   Log:
>   WARNS-2'ify.
>   (this included removing the funny "if (unsigned_var < 0)" test)

Why not make the 'ul' variable (icky name) a long and use strtol() instead? 
Then you don't need all the (unsigned) casts for all the comparisons.

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010730103342.jhb>