Date: Wed, 22 Feb 2006 15:48:33 +0100 From: Ulrich Spoerlein <q@galgenberg.net> To: Divacky Roman <xdivac02@stud.fit.vutbr.cz> Cc: current@freebsd.org Subject: Re: Bad code in rcorder(8) (Was: Re: New RCorder: abi loaded too late) Message-ID: <20060222144833.GA1124@galgenberg.net> In-Reply-To: <20060222142058.GB43749@stud.fit.vutbr.cz> References: <20060217181842.GA21033@odin.ac.hmc.edu> <43F65A70.7080608@FreeBSD.org> <20060217234118.GA22643@odin.ac.hmc.edu> <43F67121.5080809@FreeBSD.org> <43F682F2.1020804@FreeBSD.org> <43F68611.7080602@FreeBSD.org> <20060219110732.GA12550@stud.fit.vutbr.cz> <43F8ABC8.30005@FreeBSD.org> <20060221180440.GB2996@galgenberg.net> <20060222142058.GB43749@stud.fit.vutbr.cz>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Divacky Roman wrote: > well. there are leaks :) if you try the > http://www.freebsd.org/cgi/query-pr.cgi?pr=91789 > > I think you'll get touch-after-free as well Ah I see. I first tried this with rcorder from early January and I got errors from 20 different contexts. I now just checked out a fresh rcorder from RELENG_6 and there are still two problems remaining. So the patch in the PR did not address all problems. Here's the output ... /etc/rc.d/ipfw /etc/rc.d/nsswitch rcorder: Circular dependency on file `/etc/rc.d/NETWORKING'. ==3431== Invalid read of size 4 ==3431== at 0x80499B0: satisfy_req (rcorder.c:654) ==3431== by 0x804979A: do_file (rcorder.c:758) ==3431== by 0x80499DA: satisfy_req (rcorder.c:686) ==3431== by 0x804979A: do_file (rcorder.c:758) ==3431== Address 0x3C1E6AEC is 0 bytes inside a block of size 8 free'd ==3431== at 0x3C03267F: free (in /usr/local/lib/valgrind/vgpreload_memcheck.so) ==3431== by 0x80497B2: do_file (rcorder.c:761) ==3431== by 0x80499DA: satisfy_req (rcorder.c:686) ==3431== by 0x804979A: do_file (rcorder.c:758) ==3431== ==3431== Invalid read of size 4 ==3431== at 0x80497A5: do_file (rcorder.c:759) ==3431== by 0x80499DA: satisfy_req (rcorder.c:686) ==3431== by 0x804979A: do_file (rcorder.c:758) ==3431== by 0x80499DA: satisfy_req (rcorder.c:686) ==3431== Address 0x3C1E6AF0 is 4 bytes inside a block of size 8 free'd ==3431== at 0x3C03267F: free (in /usr/local/lib/valgrind/vgpreload_memcheck.so) ==3431== by 0x80497B2: do_file (rcorder.c:761) ==3431== by 0x80499DA: satisfy_req (rcorder.c:686) ==3431== by 0x804979A: do_file (rcorder.c:758) rcorder: Circular dependency on provision `fake_prov_00000006' in file `/etc/rc.d/NETWORKING'. /etc/rc.d/ip6addrctl /etc/rc.d/atm2 ... ==3431== ==3431== ERROR SUMMARY: 4 errors from 2 contexts (suppressed: 0 from 0) ==3431== malloc/free: in use at exit: 17128 bytes in 536 blocks. ==3431== malloc/free: 3579 allocs, 3043 frees, 631699 bytes allocated. hth, Ulrich Spoerlein -- PGP Key ID: 20FEE9DD Encrypted mail welcome! Fingerprint: AEC9 AF5E 01AC 4EE1 8F70 6CBD E76E 2227 20FE E9DD Which is worse: ignorance or apathy? Don't know. Don't care. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD/HnB524iJyD+6d0RAphfAJ9pFi31m8kPqIBGiskg+WVmq/iJpgCfeJPG S7x8J+/4ghXb9kodGnYpLJk= =GGgT -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060222144833.GA1124>