Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Mar 2017 11:30:42 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Chagin Dmitry <dchagin@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org
Subject:   Re: svn commit: r315959 - in head/sys: amd64/amd64 amd64/vmm amd64/vmm/amd i386/i386 x86/include x86/x86 x86/xen
Message-ID:  <1349a6c5-0fe3-b873-f372-4ec9046fa71f@FreeBSD.org>
In-Reply-To: <20170326083021.GA1899@mordor.heemeyer.club>
References:  <201703251845.v2PIj9k2029497@repo.freebsd.org> <20170326083021.GA1899@mordor.heemeyer.club>

next in thread | previous in thread | raw e-mail | index | archive | help
On 03/26/2017 11:30, Chagin Dmitry wrote:
> On Sat, Mar 25, 2017 at 06:45:09PM +0000, Andriy Gapon wrote:
>> Author: avg
>> Date: Sat Mar 25 18:45:09 2017
>> New Revision: 315959
>> URL: https://svnweb.freebsd.org/changeset/base/315959
>>
>> Log:
>>   specific end of interrupt implementation for AMD Local APIC
>>   
>>   The change is more intrusive than I would like because the feature
>>   requires that a vector number is written to a special register.
>>   Thus, now the vector number has to be provided to lapic_eoi().
>>   It was readily available in the IO-APIC and MSI cases, but the IPI
>>   handlers required more work.
>>   Also, we now store the VMM IPI number in a global variable, so that it
>>   is available to the justreturn handler for the same reason.
>>   
>>   Reviewed by:	kib
>>   MFC after:	6 weeks
>>   Differential Revision: https://reviews.freebsd.org/D9880
>>
>> Modified:
>>   head/sys/amd64/amd64/apic_vector.S
>>   head/sys/amd64/amd64/genassym.c
> 
> 
> 
> Hi, Andriy, u broke the build
> 
> 
> /usr/local/bin/clang40 -c -O2 -pipe -fno-strict-aliasing -g -nostdinc -I. -I/home/git/head/sys -I/home/git/head/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.genassym.o -MTgenassym.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 /home/git/head/sys/amd64/amd64/genassym.c
> In file included from /home/git/head/sys/amd64/amd64/genassym.c:47:
> /home/git/head/sys/sys/bus.h:730:10: fatal error: 'device_if.h' file not found
> #include "device_if.h"
>          ^~~~~~~~~~~~~
> 1 error generated.
> *** Error code 1

I've got another report about this problem, but I can not reproduce it here with
a clean kernel build of GENERIC.
I am not sure what the problem is.
Do you have anything unusual in make.conf, src.conf or your kernel configuration?

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1349a6c5-0fe3-b873-f372-4ec9046fa71f>