Date: Sat, 23 May 2009 21:27:46 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Sam Leffler <sam@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, Rick Macklem <rmacklem@FreeBSD.org>, Alexey Dokuchaev <danfe@FreeBSD.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r192591 - head/sys/fs/nfsserver Message-ID: <20090523210556.Y826@delplex.bde.org> In-Reply-To: <4A16F40B.4020404@freebsd.org> References: <200905221810.n4MIAe4J014419@svn.freebsd.org> <20090522184846.GA34437@FreeBSD.org> <4A16F40B.4020404@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 22 May 2009, Sam Leffler wrote:
> Alexey Dokuchaev wrote:
>> On Fri, May 22, 2009 at 06:10:40PM +0000, Rick Macklem wrote:
>>> ...
>>> Log:
>>> Modified the printf message of r192590 to remove the
>>> possible DOS attack, as suggested by Sam.
>>> - printf("out of clientids, possible DOS attack\n");
>>> + printf("out of clientids\n");
>>>
>>
>> Previously, panic() message referred "nfs4", now it does not, making it
>> rather cryptic without grepping through the source code.
>> .
> I requested the printf identify the call site; e.g.
>
> printf("%s: out of clientids\n", __func__);
That is equally cryptic _with_ grepping through the source code, and
much uglier. __func__ should only be used when the function name is
not a literal constant (mainly in macros). The new nfs code only uses
__func__ in 2 places, now including this one. The old nfs code only
uses it in a few more than 2 places.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090523210556.Y826>