Date: Mon, 3 Aug 2015 11:31:58 +0100 From: Steven Hartland <steven@multiplay.co.uk> To: Slawa Olhovchenkov <slw@zxy.spb.ru> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <55BF431E.3020601@freebsd.org> In-Reply-To: <20150803094730.GA24698@zxy.spb.ru> References: <201508030934.t739YAkT026668@repo.freebsd.org> <20150803094730.GA24698@zxy.spb.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/08/2015 10:47, Slawa Olhovchenkov wrote: > On Mon, Aug 03, 2015 at 09:34:10AM +0000, Steven Hartland wrote: > >> Author: smh >> Date: Mon Aug 3 09:34:09 2015 >> New Revision: 286223 >> URL: https://svnweb.freebsd.org/changeset/base/286223 >> >> Log: >> Fix KSTACK_PAGES check in ZFS module >> >> The check introduced by r285946 failed to add the dependency on >> opt_kstack_pages.h which meant the default value for the platform instead >> of the customised options KSTACK_PAGES=X was being tested. >> >> Also wrap in #ifdef __FreeBSD__ for portability. > /usr/src/sys/kern/kern_proc.c:int kstack_pages = KSTACK_PAGES; > > May be check variable kstack_pages is best way? > Eliminate dependency on foreign opt_XXXX. > I did think of that but as other modules such as dtrace, which is also cddl code, already have this dependency I went with this. I'm easy though, if there's a concusses that kstack_pages or possibly curthread->td_kstack_pages, which would take into account the possibility of varied thread stack sizes, then I can make that change. What do others think? Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55BF431E.3020601>