Date: Mon, 07 Jul 2008 19:54:51 +0200 From: Pietro Cerutti <gahr@FreeBSD.org> To: Max Khon <fjoe@samodelkin.net> Cc: Max Khon <fjoe@FreeBSD.org>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/dmucs Makefile ports/devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h patch-dmucs_msg.cc patch-main.cc Message-ID: <4872586B.3010706@FreeBSD.org> In-Reply-To: <487251C7.7060102@samodelkin.net> References: <200807071617.m67GHsHA058914@repoman.freebsd.org> <48724635.80406@FreeBSD.org> <487251C7.7060102@samodelkin.net>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Max Khon wrote: | Hello! Hello! | | Pietro Cerutti wrote: | |> -----BEGIN PGP SIGNED MESSAGE----- |> Hash: SHA512 |> |> Max Khon wrote: |> | fjoe 2008-07-07 16:17:54 UTC |> | |> | FreeBSD ports repository |> | |> | Modified files: |> | devel/dmucs Makefile |> | Added files: |> | devel/dmucs/files patch-dmucs_db.cc patch-dmucs_db.h |> | patch-dmucs_msg.cc patch-main.cc |> | Log: |> | Unbreak on 64-bit archs |> |> I definitely do not agree. Please note that a pointer is not required to |> fit into a long, while it is required to fit into a size_t. |> |> Your solution may work as soon as we are concerned only with LP64 |> machines. As soon as a LLP64 arch steps in, you break things. | | AFAIK it is not guaranteed that sizeof(void *) <= sizeof(size_t) too. | I used "long" because I did not want to cope with "[u]intptr_t" there. | | Ok, I committed a modified patch that uses "const void *" instead of | "long". You are right (see my follow-up to ports@). Anyway, it seems to be ok now :) | | /fjoe - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (FreeBSD) iEYEAREKAAYFAkhyWGoACgkQwMJqmJVx945UEACfa59PMGHy+m2ANLohTgqKm5Zu HhcAoMlrXByiwIyt85VPEramaYeDsz64 =RLu9 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4872586B.3010706>