Date: Wed, 6 May 1998 12:03:12 +0200 (MET DST) From: Cejka Rudolf <xcejka00@dcse.fee.vutbr.cz> To: bde@zeta.org.au (Bruce Evans) Cc: freebsd-bugs@FreeBSD.ORG, phk@FreeBSD.ORG, xcejka00@dcse.fee.vutbr.cz Subject: Re: bin/6521: Wait with commit please Message-ID: <199805061003.KAA19547@sts.dcse.fee.vutbr.cz> In-Reply-To: <199805051741.DAA28205@godzilla.zeta.org.au> from Bruce Evans at "May 6, 98 03:41:20 am"
next in thread | previous in thread | raw e-mail | index | archive | help
> > Here is a small patch. But I don't think, it is the best solution: > > It is essentially identical with the buggy code that I removed in > rev.1.7 :-). It breaks `rmdir -p symlink/' where `symlink' is > a symlink to a directory and has some buffer underrun problems. > I think the symlink case can be handled properly by doing the > first rmdir before stripping and then checking if the supposedly > removed final path component is still there. The latter is just > to give a better error messsage (ENOTDIR for hitting a symlink > instead of ENOTEMPTY for attempting to remove a nonempty directory > containing a symlink). Note that `rmdir -p symlink/bar' does > not remove `symlink/', although `rmdir -p symlink/' does, since > there is nothing special about an intermediate slash. > > Bruce Now I'm looking, bin/6521 is suspended and waiting for commiters. Please wait, Bruce sent this mail to me. It is major - It needs some discussion at this time I think. Isn't best time to specify requirements for rmdir now and put them as comment in rmdir.c too (and fix rmdir)? -------------------------------------------------------------------------- Rudolf Cejka E-mail: xcejka00@dcse.fee.vutbr.cz Technical University of Brno, Faculty of El. Engineering and Comp. Science Bozetechova 2, 612 66 Brno, Czech Republic To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805061003.KAA19547>