Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Mar 2002 12:59:43 -0800 (PST)
From:      Julian Elischer <julian@elischer.org>
To:        Giorgos Keramidas <keramida@freebsd.org>
Cc:        hackers@freebsd.org
Subject:   Re: RFC: style(9) isn't explicit about booleans for testing.
Message-ID:  <Pine.BSF.4.21.0203051255520.26829-100000@InterJet.elischer.org>
In-Reply-To: <20020305201350.GC4820@hades.hell.gr>

next in thread | previous in thread | raw e-mail | index | archive | help


On Tue, 5 Mar 2002, Giorgos Keramidas wrote:
> > 
> > Read the man page to try and decide if you should write "if (x)" or
> > if (x != 0).
> > 
> > >Fix:
> > 
> > Apply the attached page to the style(9) man page.
[...]

the one that I stop to think about is:

if (!(flags & FLAGSET))

or should that be 

if ((flags & FLAGSET) == 0)

it depends on what you define as a Boolean.

If FLAGSET has > 1 bit in it then it it still possibly a boolean?





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0203051255520.26829-100000>