Date: Thu, 29 Jan 2015 19:53:37 +0000 From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 197184] x11/libxkbfile: fix build with clang 3.6.0 Message-ID: <bug-197184-7141-Mdm3vQ6abd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197184-7141@https.bugs.freebsd.org/bugzilla/> References: <bug-197184-7141@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
Dmitry Marakasov <amdmi3@FreeBSD.org> has reassigned Bugzilla Automation <bugzilla@FreeBSD.org>'s request for maintainer-feedback to x11@FreeBSD.org: Bug 197184: x11/libxkbfile: fix build with clang 3.6.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197184 --- Description --- Created attachment 152348 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D152348&action= =3Dedit Patch I'm testing ports building on experimental projects/clang360-import branch,= and libxkbfile fails there because of more strict warnings of clang 3.6: --- =3D=3D=3D> Building for libxkbfile-1.0.8_2 /usr/bin/make all-recursive Making all in src CC cout.lo cout.c:48:46: error: address of array 'xkb->names->vmods' will always evalu= ate to 'true' [-Werror,-Wpointer-bool-conversion] if ((!xkb)||(!xkb->names)||(!xkb->names->vmods)) ~~~~~~~~~~~~~^~~~~ 1 error generated. *** Error code 1 --- The vmods member is really an array, so the warning is valid. The fix is to remove the useless check. It was already fixed upstream: http://cgit.freedesktop.org/xorg/lib/libxkbfile/commit/?id=3D9fa04388dcbb5b= f20531 9569f540a62c03754688 --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer x11@FreeBSD.org=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197184-7141-Mdm3vQ6abd>