Date: Sun, 12 Sep 2004 19:36:37 +0200 (CEST) From: Dan Lukes <dan@obluda.cz> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/71669: [PATCH] cleanup of the usr.sbin/atm code Message-ID: <200409121736.i8CHab2k010919@kulesh.obluda.cz> Resent-Message-ID: <200409121740.i8CHeRMI009154@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 71669 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/atm code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 17:40:27 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 i386 usr.sbin/atm/scspd/scsp_hfsm.c,v 1.4 2002/10/10 00:32:55 alfred usr.sbin/atm/scspd/scsp_socket.c,v 1.4 2002/05/16 23:57:37 arr >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/atm/scspd/scsp_hfsm.c:132: warning: implicit declaration of function `abort' usr.sbin/atm/scspd/scsp_socket.c:320: warning: enumeration value `MEDIA_UTP25' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:320: warning: enumeration value `MEDIA_VIRTUAL' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:320: warning: enumeration value `MEDIA_DSL' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:507: warning: enumeration value `MEDIA_UTP25' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:507: warning: enumeration value `MEDIA_VIRTUAL' not handled in switch usr.sbin/atm/scspd/scsp_socket.c:507: warning: enumeration value `MEDIA_DSL' not handled in switch >How-To-Repeat: N/A >Fix: *** usr.sbin/atm/scspd/scsp_socket.c.ORIG Mon Jul 1 23:51:35 2002 --- usr.sbin/atm/scspd/scsp_socket.c Sun Sep 12 16:56:39 2004 *************** *** 316,321 **** --- 316,322 ---- traffic.backward.PCR_all_traffic = ATM_PCR_OC12C; break; case MEDIA_UNKNOWN: + default: break; } *************** *** 503,508 **** --- 504,510 ---- traffic.backward.PCR_all_traffic = ATM_PCR_OC12C; break; case MEDIA_UNKNOWN: + default: break; } *** usr.sbin/atm/scspd/scsp_hfsm.c.ORIG Sat Oct 12 03:59:55 2002 --- usr.sbin/atm/scspd/scsp_hfsm.c Sun Sep 12 16:57:38 2004 *************** *** 51,56 **** --- 51,57 ---- #include <errno.h> #include <libatm.h> #include <stdio.h> + #include <stdlib.h> #include <syslog.h> #include "scsp_msg.h" >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409121736.i8CHab2k010919>