Date: Tue, 09 May 2023 09:43:27 +0200 From: Corvin =?ISO-8859-1?Q?K=F6hne?= <corvink@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 76887e84be97 - main - cpuset: increase userland maximum size to 1024 Message-ID: <2f47388ab07eaeb820344e928adb96ff6f7a5916.camel@FreeBSD.org> In-Reply-To: <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org> References: <202305081826.348IQm9N040108@gitrepo.freebsd.org> <0dadaa17917629e3399fe9acbab17eb60b63575d.camel@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, 2023-05-09 at 08:59 +0200, Corvin Köhne wrote: > On Mon, 2023-05-08 at 18:26 +0000, Ed Maste wrote: > > The branch main has been updated by emaste: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=76887e84be975698b14699d7d0dfb157d73e9990 > > > > commit 76887e84be975698b14699d7d0dfb157d73e9990 > > Author: Ed Maste <emaste@FreeBSD.org> > > AuthorDate: 2023-05-02 20:57:12 +0000 > > Commit: Ed Maste <emaste@FreeBSD.org> > > CommitDate: 2023-05-08 18:25:15 +0000 > > > > cpuset: increase userland maximum size to 1024 > > > > Hardware with more than 256 CPU cores is now available and will > > become > > increasingly common. Bump CPU_MAXSIZE (used for userland > > cpuset_t > > sizing) to 1024 to define the ABI for FreeBSD 14. > > > > PR: 269572, 271213 [exp-run] > > Reviewed by: mjg, jhb > > Relnotes: yes > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D39941 > > --- > > sys/sys/_cpuset.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/sys/_cpuset.h b/sys/sys/_cpuset.h > > index b75ee595da3c..676f9855f384 100644 > > --- a/sys/sys/_cpuset.h > > +++ b/sys/sys/_cpuset.h > > @@ -40,7 +40,7 @@ > > #define CPU_SETSIZE MAXCPU > > #endif > > > > -#define CPU_MAXSIZE 256 > > +#define CPU_MAXSIZE 1024 > > > > #ifndef CPU_SETSIZE > > #define CPU_SETSIZE CPU_MAXSIZE > > Hi Ed, > > this somehow breaks bhyve on my system. It immediately exits with > "vm_run error -1" on startup. > > Setting MAXCPU [1] to 1024 as well, solves the issue. Not sure if it's a regression of your commit or a bhyve bug. [1] https://github.com/freebsd/freebsd-src/blob/20d8d9809a8c0a3ddd1d0156e77ec53a1ed95747/sys/amd64/include/param.h#L68 -- Kind regards, Corvin [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmRZ+Z8ACgkQ2FTaVjFe AmpXDw//RmtEeG1ABYr0cB2YtkfNQ/KyNZEt3VserTF07bBh5c7YHe2EVaiLeO2P vKMLquiaKenGs7XnlMtCF3wBOg3bA2ohpLnK9Vmq9wEYnISDiixmZNm//3zaNCE2 WPg52219MadO+It5zlR57WxX9pywfnroFirfscaglowrAYPRAFGooM0WKpPZwIym 5FFlrUoFWFwBnD/fo/MiOEFWJ7l8hChUXyiwZhnktovHtLheOn9fc+iENYV0EHGp 1JTT6nd8KSHJac2SRFfSA8SlO9vwNVyEk4rPC7chKfraJrX3F92P2VR4JIwunm4C wOiCg0FEtgyspcD5Db1dfqI7OgP0VakACzQuUuCWUv3enzsX6V7M4DmC9wPa9E5B CGobxy+XDzo5dVCWW6+rZmPWOsoFyu5AGSx38oqDgjBvJQ7qplG3ScqqdRKxbAOP J81EILuQmgXFZ1suD6mvYCPaQ7e6MMqhMGH/oG8sx8+CRbcBZxvmSbZiC+2ibUPM X5bTuj0lh9xrI1Ps7/xkBpprMPEJw8fY/usBLTsTZdLsRBp7dZ9YjHTGK+keDXWm uMNtWl8Nyv+yeb+LRrfupBpE5YMZJFSIWh2vsd/0B+Z+OFLFTPteXM0bIIJNR/8r +BPRNpF4ysZ7H4mKuEFDvizLq6l4gUOwdDHKfu5U6oLiQjI+4aU= =3yGb -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2f47388ab07eaeb820344e928adb96ff6f7a5916.camel>