Date: Sun, 14 Nov 2004 08:23:48 +0800 From: Yen-Ming Lee <leeym@FreeBSD.org> To: Don Croyle <croyle@gelemna.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: ports/news/p5-News-Article Makefile pkg-descr Message-ID: <20041114002347.GA71813@utopia.leeym.com> In-Reply-To: <419699CE.8060301@gelemna.org> References: <gelemna.lists.freebsd.cvs/200411130457.iAD4veNM065684@repoman.freebsd.org> <419699CE.8060301@gelemna.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--R3G7APHDIzY6R/pk Content-Type: multipart/mixed; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=big5 Content-Disposition: inline On Sat, Nov 13, 2004 at 06:33:34PM -0500, Don Croyle wrote: > Yen-Ming Lee wrote: > >leeym 2004-11-13 04:57:40 UTC > > > > FreeBSD ports repository > > > > Modified files: > > news/p5-News-Article Makefile pkg-descr > > Log: > > - remove redundant dependency > > The News::NNTP included in the perl distribution might be suitable, but > I would prefer to use the one from the net/p5-Net port. > > You also removed the dependency on PGP::Sign from the > security/p5-PGP-Sign port. I realize that News::Article can be used for > any number of things, but it was originally written with Usenet > moderation in mind. The pgp hooks are there for that purpose and the > dependency is called for in the module's README. Hmm, I tried to parse an article on usenet today, and I don't need PGP since I don't want GnuPG, which I prefer, to conflict with PGP related stuff. These two modules don't appear in PREREQ_PM in Makefile.PL, therefore I think that News::Article should work without these two modules, so I removed it. How about make it optional dependency which is turned ON by default? please take a look on the attached patch. > > - add WWW in pkg-descr > http://www.erlenstar.demon.co.uk/perl/ would be a better choice. Okay, this one would be better. :) regards, -- Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=big5 Content-Disposition: attachment; filename="p5-News-Article.diff" Index: Makefile =================================================================== RCS file: /home/pcvs/ports/news/p5-News-Article/Makefile,v retrieving revision 1.18 diff -u -r1.18 Makefile --- Makefile 13 Nov 2004 04:57:40 -0000 1.18 +++ Makefile 14 Nov 2004 00:17:50 -0000 @@ -16,9 +16,21 @@ MAINTAINER= ports@FreeBSD.org COMMENT= Object for handling Usenet articles in mail or news form +BUILD_DEPENDS= ${SITE_PERL}/Net/NNTP.pm:${PORTSDIR}/net/p5-Net +RUN_DEPENDS= ${SITE_PERL}/Net/NNTP.pm:${PORTSDIR}/net/p5-Net + PERL_CONFIGURE= yes MAN3= News::Article.3 News::AutoReply.3 News::FormArticle.3 \ News::FormReply.3 -.include <bsd.port.mk> +OPTIONS= PGP_SIGN "PGP::Sign support for Usenet moderation" on + +.include <bsd.port.pre.mk> + +.if !defined(WITHOUT_PGP_SIGN) +BUILD_DEPENDS+= ${SITE_PERL}/PGP/Sign.pm:${PORTSDIR}/security/p5-PGP-Sign +RUN_DEPENDS+= ${SITE_PERL}/PGP/Sign.pm:${PORTSDIR}/security/p5-PGP-Sign +.endif + +.include <bsd.port.post.mk> Index: pkg-descr =================================================================== RCS file: /home/pcvs/ports/news/p5-News-Article/pkg-descr,v retrieving revision 1.2 diff -u -r1.2 pkg-descr --- pkg-descr 13 Nov 2004 04:57:40 -0000 1.2 +++ pkg-descr 14 Nov 2004 00:17:50 -0000 @@ -2,4 +2,4 @@ from various data sources; various header manipulations, and posting via NNTP or mailing via a sendmail-workalike. -WWW: http://search.cpan.org/dist/News-Article/ +WWW: http://www.erlenstar.demon.co.uk/perl/ --82I3+IH0IqGh5yIs-- --R3G7APHDIzY6R/pk Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iQCVAwUBQZalk8nMx0NetS5RAQFnjwQA2931kkU18ru5hFGUvGmLcMt6sIks0NdH kkac1P7CkuU4/HGc+MxZ+lEakgMOe9+Nwpzr797fRa+vC31mgmyvBB1dICa9ua8y 2NjbmGIkV1iIxAyLVmSFic4KwroPRqcqaTPmT3V8HEHGNRx9hsRUvlkv10q3IrTB TIH9DH4kBVM= =GfB5 -----END PGP SIGNATURE----- --R3G7APHDIzY6R/pk--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041114002347.GA71813>