Date: Mon, 28 Oct 2024 22:43:23 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 73979b7f0bac - main - camcontrol: Bump timeout to get size of drive Message-ID: <202410282243.49SMhN8W085318@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=73979b7f0bac44a9b647c872ade17f4f7021a5e4 commit 73979b7f0bac44a9b647c872ade17f4f7021a5e4 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2024-10-28 22:33:07 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2024-10-28 22:43:25 +0000 camcontrol: Bump timeout to get size of drive When the system is very busy, and the ATA hard disk drives are overloaded due to reading dodgy sectors, it can take several seconds to drain the NCQ set of commands to send this command to the drive. Up the timeout from 5s to 10s out of an abundance of caution, but also to allow monitioring software that uses camcontrol identify to not fail needlessly. Sponsored by: Netflix --- sbin/camcontrol/camcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/camcontrol/camcontrol.c b/sbin/camcontrol/camcontrol.c index b7ad7f7d4b25..a2e65055fcaa 100644 --- a/sbin/camcontrol/camcontrol.c +++ b/sbin/camcontrol/camcontrol.c @@ -2102,7 +2102,7 @@ ata_read_native_max(struct cam_device *device, int retry_count, /*sector_count*/0, /*data_ptr*/NULL, /*dxfer_len*/0, - timeout ? timeout : 5000, + timeout ? timeout : 10 * 1000, is48bit); if (error)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202410282243.49SMhN8W085318>