Date: Wed, 6 Dec 2023 11:57:58 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= <dumbbell@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 14dcd4098374 - main - linuxkpi: `GFP_KERNEL` equals `M_NOWAIT` now Message-ID: <ZXBFpvGzHx9FxmuC@kib.kiev.ua> In-Reply-To: <e7322d72-05fb-476a-ab7b-0c5310e393de@FreeBSD.org> References: <202311241731.3AOHVsEJ061730@gitrepo.freebsd.org> <ZW-3rwaYDW8LbTaj@kib.kiev.ua> <e7322d72-05fb-476a-ab7b-0c5310e393de@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Dec 06, 2023 at 09:46:53AM +0100, Jean-Sébastien Pédron wrote: > On 06/12/2023 00:52, Konstantin Belousov wrote: > > Unfortunately this broke even attach of the mlx5(4) driver. > > According to the 'official' Linux kernel documentation, the GFP_KERNEL > > flag implies sleepable context. mlx5_core uses the passed GFP flag to > > determine if it is called in the sleepable context, and now even initial > > load assumes that it cannot perform sleeping ops. See, for instance, > > second if() statement in the mlx5_fwp_alloc() function. > > Oh sorry... Thank you for reporting the issue. I will revisit this change > then. Should I revert it in main until there is a solution? Up to you. I do not see a need in churn if the fix would come in several days. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZXBFpvGzHx9FxmuC>