Date: Mon, 06 Mar 2006 17:16:19 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: scottl@samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org, nate@root.org Subject: Re: cvs commit: src/sys/dev/usb umass.c Message-ID: <20060306.171619.38885944.imp@bsdimp.com> In-Reply-To: <440CCB02.4080905@samsco.org> References: <440B41DF.1010305@root.org> <20060306.162218.20524465.imp@bsdimp.com> <440CCB02.4080905@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <440CCB02.4080905@samsco.org>
Scott Long <scottl@samsco.org> writes:
: M. Warner Losh wrote:
: > In message: <440B41DF.1010305@root.org>
: > Nate Lawson <nate@root.org> writes:
: > : Poul-Henning Kamp wrote:
: > : > phk 2006-03-05 17:52:32 UTC
: > : >
: > : > FreeBSD src repository
: > : >
: > : > Modified files:
: > : > sys/dev/usb umass.c
: > : > Log:
: > : > When we get an unknown ATAPI comand, try it even if it is not listed,
: > : > in all likelyhood just passing it through will work.
: > : >
: > : > Revision Changes Path
: > : > 1.134 +4 -2 src/sys/dev/usb/umass.c
: > :
: > : Given that most umass devices can't even handle the commands required by
: > : the spec (RBC), this seems dangerous. Still, might be worth trying in
: > : HEAD just to see what commands it needs to support.
: >
: > It depends on the umass device. The thumb drives are universally
: > stupid and fragile. This change is dangerous for them (although why
: > one would send arbitrary commands to them I know not). There are a
: > number of usb2 to PATA or SATA that this fix is the right thing to do,
: > since for those it is required to get things like cdrecord to run w/o
: > complaint.
: >
: > Warner
:
: What would likely have been safer, and I meant to discuss this with PHJK
: but forgot, is to only pass commands that are 10 bytes long, and
: summarily reject all others.
I'm happy to test out whatever modifications you come up with. I
noticed phk's hack because it conflicted with my hack when I
merged...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060306.171619.38885944.imp>