Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Mar 2015 13:11:07 +0100
From:      Alexandre Martins <alexandre.martins@stormshield.eu>
To:        freebsd-current@freebsd.org
Cc:        "Andrey V. Elsukov" <bu7cher@yandex.ru>
Subject:   Re: Mbuf leak in if_lagg.c
Message-ID:  <3503024.JPjPSR4hce@pc-alex>
In-Reply-To: <551467C9.3000103@yandex.ru>
References:  <1708955.mQ2X6OUmTD@pc-alex> <55146124.2070501@yandex.ru> <551467C9.3000103@yandex.ru>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
Le jeudi 26 mars 2015, 23:10:49 Andrey V. Elsukov a crit :
> On 26.03.2015 22:42, Andrey V. Elsukov wrote:
> >> If lp_detaching is non 0, the mbuf pointer is set to NULL without m_freem
> >> it.
> >> 
> >> Can you look at this ?
> > 
> > Hi,
> > 
> > what you thing about this patch?
> > lp_detaching can be non zero in case of parent interface departure.
> > So I don't see the reason to call ETHER_BPF_MTAP() in this case.
> 
> Now I see the reason - to capture all received packets before interface
> departure. New is attached.

Sounds good for me :)

-- 
Alexandre Martins
STORMSHIELD


[-- Attachment #2 --]
0	*H
010	+0	*H
00n0
	*H
0H10	UFR10U
STORMSHIELD1#0!UStormshield Root Authority0
140904150710Z
240901150710Z0I10	UFR10U
STORMSHIELD1$0"UStormshield Users Authority0"0
	*H
0
‡X6[t.DUge0-2;h@eȻClΫpB#M,FY=.{ya{2πߢ
7	<d~O;ޅԋ&C8ُ6@CXX>|abqenmI,	O—&'۰@%OhW&
{52D%_8#f]G0ct y\v0t0Uml||uu4[ׁ0U#0BgDaP0U00U0	`HB0
	*H
N9-؞>m-K!M-7zD6IZʾr>q?u
?xr6_'NջZ7]V\5Y&))m@~^Qdp/H3ͦ`o⬋U,z,0Bdp!C2K8.r>0-1!C%3U2ϠMg~3͟wͲAZ&vF/BA$_ڀV!
s7)=-nP>qH~g/Rs,PAJVm#QXJo
*/󞁃V|sĿj~y߽j
3]v3ƌqe`Y|HB3lC!^J2$4A`Z+(7b{e˄wʈ<L=6[3`>IQFaiܝ ?:_yԊ
/`00ޠ(0
	*H
0I10	UFR10U
STORMSHIELD1$0"UStormshield Users Authority0
140904151038Z
150904151038Z0p10	UFR10U
STORMSHIELD10UAlexandre MARTINS1/0-	*H
	 alexandre.martins@stormshield.eu0"0
	*H
0
'l(bOx<yliĻT$}C1#quQ^On^H"Ca9e1`s	+:Bu8xAIE<{H*KbҚ$(dz EkUXfצ+돩T'xOחv9LOtrZߤʭŜʨc͈F
13/E;NV̓Xđ_QHt@J;F'`'rregC00UH+R6"60U#0ml||uu4[ׁ0	U00U0+U$0" alexandre.martins@stormshield.eu0	`HB0U%0++0
	*H
G07 i֗^Qځ
;7	T8%M
.Ӛɼ,K=^I_Y+0y@5*rԲ>7cb\+$%'|zenOA\Aη;ڋZA1?Tru13?>>/ٓyC]#Lԉ.?<GΌqN׹jU2k`?u;&)H4AXQº\x*C9#55TR#+{d7Je^m100R0I10	UFR10U
STORMSHIELD1$0"UStormshield Users Authority(0	+0	*H
	1	*H
0	*H
	1
150327121107Z0#	*H
	1M6 _`D?+|00(	*H
	100	`He0
*H
0
	*H
Wwؠ}B"<VzzͿon
[	
-)d`իqAL"Ɇqɚ~1Gb-h6nPltYKsm.vc| 2wq%l4k)ufێE	c/
 P(duP"h|5ځ&_7N}T_$ȑmTl)QVL.xz%F/=CyLT<I!
home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3503024.JPjPSR4hce>