Date: Mon, 27 Dec 2004 19:17:36 +0100 (CET) From: Julien Gabel <jpeg@thilelli.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/75550: [PATCH] Make more visible printing when defining vars before make-ing Message-ID: <20041227181736.B74077301B@titeuf.thilelli.net> Resent-Message-ID: <200412271820.iBRIKB86089377@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 75550
>Category: ports
>Synopsis: [PATCH] Make more visible printing when defining vars before make-ing
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Dec 27 18:20:11 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Julien Gabel
>Release: FreeBSD 5.3-STABLE i386
>Organization:
>Environment:
System: FreeBSD bento.thilelli.net 5.2.1-RELEASE-p13 FreeBSD 5.2.1-RELEASE-p13 #0: Mon Dec 27 13:35:53 CET 2004 root@bento.thilelli.net:/usr/obj/usr/src/sys/BENTO i386
>Description:
After a fresh installation of mail/dspam (/var/db/pkg/dspam-3.2.3.20041218.2100_1), some printing
when defining vars before make-ing may be more informative.
In this patch, the following modification were made:
- Print the default value (with vars) _and_ the defined value if any;
- Correct a little mistake in the default value of DSPAM_HOME.
>How-To-Repeat:
Go to /usr/ports/mail/dspam and type 'make extract' will suffice.
>Fix:
# diff -ruN /usr/ports/mail/dspam/Makefile.orig /usr/ports/mail/dspam/Makefile
--- /usr/ports/mail/dspam/Makefile.orig Mon Dec 27 17:04:51 2004
+++ /usr/ports/mail/dspam/Makefile Mon Dec 27 18:09:01 2004
@@ -522,15 +522,15 @@
@${ECHO_CMD} "Define vars below before make-ing if you need:"
@${ECHO_CMD} ""
- @${ECHO_CMD} "SIGNATURE_LIFE (default 15)"
- @${ECHO_CMD} "DSPAM_OWNER (default: root)"
- @${ECHO_CMD} "DSPAM_GROUP (default: mail)"
+ @${ECHO_CMD} "SIGNATURE_LIFE = ${SIGNATURE_LIFE} (default 15)"
+ @${ECHO_CMD} "DSPAM_OWNER = ${DSPAM_OWNER} (default: root)"
+ @${ECHO_CMD} "DSPAM_GROUP = ${DSPAM_GROUP} (default: mail)"
@${ECHO_CMD} "DSPAM_MODE"
- @${ECHO_CMD} "DSPAM_HOME (default: ${_VAR_DIR}/dspam)"
+ @${ECHO_CMD} "DSPAM_HOME = ${DSPAM_HOME} (default: ${_VAR_DIR}/db/dspam)"
@${ECHO_CMD} "DSPAM_HOME_OWNER"
@${ECHO_CMD} "DSPAM_HOME_GROUP"
- @${ECHO_CMD} "DSPAM_HOME_MODE (default: 0660)"
- @${ECHO_CMD} "LOG_DIR (default: ${_VAR_DIR}/log/dspam)"
+ @${ECHO_CMD} "DSPAM_HOME_MODE = ${DSPAM_HOME_MODE} (default: 0660)"
+ @${ECHO_CMD} "LOG_DIR = ${LOG_DIR} (default: ${_VAR_DIR}/log/dspam)"
@${ECHO_CMD} "QUARANTINE_AGENT (default: mail.local)"
. if defined(WITH_CGI)
@${ECHO_CMD} "Define CGI_PATH before make-ing if you need the CGI files"
>Release-Note:
>Audit-Trail:
>Unformatted:
accordinf to our needs.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041227181736.B74077301B>